Skip to content
This repository was archived by the owner on Jan 26, 2021. It is now read-only.

Commit c521d3d

Browse files
Sync changes from internal repo. (#100)
* Small performance tweak for DDC.
1 parent 2afec1a commit c521d3d

File tree

6 files changed

+48
-43
lines changed

6 files changed

+48
-43
lines changed

CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.7.10 - 2018-02-22
2+
3+
* Small performance tweak for DDC.
4+
15
## 0.7.9 - 2018-01-12
26

37
* Add fast getters for common types.

lib/message_generator.dart

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -321,8 +321,8 @@ class MessageGenerator extends ProtobufContainer {
321321
var names = field.memberNames;
322322

323323
_emitOverrideIf(field.overridesGetter, out);
324-
var getterExpr =
325-
_getterExpression(fieldTypeString, field.index, defaultExpr);
324+
var getterExpr = _getterExpression(
325+
fieldTypeString, field.index, defaultExpr, field.isRepeated);
326326
out.println('${fieldTypeString} get ${names.fieldName} => ${getterExpr};');
327327

328328
if (field.isRepeated) {
@@ -361,15 +361,16 @@ class MessageGenerator extends ProtobufContainer {
361361
}
362362
}
363363

364-
String _getterExpression(String fieldType, int index, String defaultExpr) {
364+
String _getterExpression(
365+
String fieldType, int index, String defaultExpr, bool isRepeated) {
365366
if (fieldType == 'String') {
366367
return '\$_getS($index, $defaultExpr)';
367368
}
368369
if (fieldType == 'Int64' && defaultExpr == 'null') {
369370
return '\$_getI64($index)';
370371
}
371372
if (defaultExpr == 'null') {
372-
return '\$_getN($index)';
373+
return isRepeated ? '\$_getList($index)' : '\$_getN($index)';
373374
}
374375
return '\$_get($index, $defaultExpr)';
375376
}

lib/src/dart_options.pb.dart

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/descriptor.pb.dart

Lines changed: 33 additions & 33 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

lib/src/plugin.pb.dart

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pubspec.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: protoc_plugin
2-
version: 0.7.9
2+
version: 0.7.10
33
author: Dart Team <[email protected]>
44
description: Protoc compiler plugin to generate Dart code
55
homepage: https://github.com/dart-lang/dart-protoc-plugin
@@ -8,7 +8,7 @@ environment:
88
dependencies:
99
fixnum: ^0.10.5
1010
path: ^1.0.0
11-
protobuf: ^0.7.0
11+
protobuf: ^0.7.1
1212
dart_style: ^1.0.6
1313
dev_dependencies:
1414
browser: any

0 commit comments

Comments
 (0)