Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

checks for overrides need fixing #13

Closed
sigmundch opened this issue Dec 23, 2014 · 1 comment
Closed

checks for overrides need fixing #13

sigmundch opened this issue Dec 23, 2014 · 1 comment

Comments

@sigmundch
Copy link
Contributor

We seem to be incorrectly checking overrides in some scenarios, for example mixins and transitive checks.

class A {}
class B extends A {}

class Base {
  A f1;
}
class M {
  B f1;
}

class Test1 extends Base {
  B f1;
}
class Test2 extends Test1 {
  B f1;
}
class Test3 extends M implements Base {}
class Test4 extends Object with M implements Base {}
class Test5 extends Base with M {}

This currently produces 2 errors, on Test1 and Test2. The one in Test2 is redundant - should we report it?

Test3 through 5 report no errors today, but they should.

@sigmundch
Copy link
Contributor Author

Also - how do we report errors for Test3..Test5 - techincally the error is in the application of the mixin, not in the mixin declaration itself

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

No branches or pull requests

2 participants