some analyzer errors are not reported

[sigmundch]

For example, this error is not reported by ddc, but reported when invoking the analyzer from the command line:

abstract class B {
  m();
}
class A implements B {}

The analyzer indicates that A should be abstract or implement m.

[jmesserly]

fwiw, I checked yesterday and this still reproduces. Very strange.

[jmesserly]

aha. We're not getting errors from ErrorVerifier:

/**
 * A visitor used to traverse an AST structure looking for additional errors and
 * warnings not covered by the parser and resolver.
 */
class ErrorVerifier extends RecursiveAstVisitor<Object> {

fwiw, that description sounds a lot like another visitor we have: CodeChecker!

[jmesserly]

yeah, it turns out very many errors/warnings/hints were not reported. wow. https://codereview.chromium.org/1183733004/