task model: Classes with call methods don't type check

[vsmenon]

In the task model branch, I'm getting an error on the assignment in main below:

class A {
  int call(String str) => 499;
}

typedef int F(String str);

void main() {
  F f = new A();
}

Error is:

severe: [AnalyzerMessage] A value of type 'A' cannot be assigned to a variable of type 'F'

No errors or warnings in bleeding_edge.

[jmesserly]

I can take a look

[jmesserly]

Looks like we used to handle this in rules.dart, getCallMethodType, which is used in various places for type checking

[jmesserly]

Strangely, that logic looks to have been ported to resolver.dart, StrongTypeSystemImpl. In fact almost this exact test case exists:

  void test_isSubtypeOf_call_method() {
    ClassElementImpl classBottom = ElementFactory.classElement2("Bottom");
    MethodElement methodBottom =
        ElementFactory.methodElement("call", objectType, <DartType>[intType]);
    classBottom.methods = <MethodElement>[methodBottom];

    DartType top = TypeBuilder.functionType(<DartType>[intType], objectType);
    InterfaceType bottom = classBottom.type;

    _checkIsStrictSubtypeOf(bottom, top);
  }

  void test_isAssignableTo_call_method() {
    ClassElementImpl classBottom = ElementFactory.classElement2("B");
    MethodElement methodBottom =
        ElementFactory.methodElement("call", objectType, <DartType>[intType]);
    classBottom.methods = <MethodElement>[methodBottom];

    DartType top = TypeBuilder.functionType(<DartType>[intType], objectType);
    InterfaceType bottom = classBottom.type;

    _checkIsAssignableTo(top, bottom);
  }

[jmesserly]

https://codereview.chromium.org/1380963004/