You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Feb 22, 2018. It is now read-only.
Normally the subtyping relation is fine, because implicit instantiation can be generated as an explicit instantiation in the generated JavaScript. However for a method override, we don't have any way to express that. It'd be a little unfortunate if all generic method calls used a different calling convention, but perhaps it's unavoidable.
The text was updated successfully, but these errors were encountered:
I am already hitting this in the wild. As the annotations are missing on the Iterable methods of the collections package, those methods are not considered to be overriding those in the core dart package. So I get warnings for them
Having a non-generic override a generic is not allowed in either strong or normal mode. If you think about it, it's kind of like optional arguments. You can add optional parameters in a subtype, but you can't take parameters away:
The short term fix is to annotate the collections package.
We've discussed doing inference. Given my first example, we could conclude that D.map needs a type parameter, which would make it D.map<T>. However the return type of Iterable<dynamic> is also problematic, unless we can conclude it too should be Iterable<T>. But we're unsure if this kind of inference is a good idea, as it's sort of analogous to inferring a missing function parameter :)
Split from #301. Something like this should be supported (or we need to explicitly disallow it):
See comments starting from #301 (comment).
Normally the subtyping relation is fine, because implicit instantiation can be generated as an explicit instantiation in the generated JavaScript. However for a method override, we don't have any way to express that. It'd be a little unfortunate if all generic method calls used a different calling convention, but perhaps it's unavoidable.
The text was updated successfully, but these errors were encountered: