Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

more care around names generated into JS #60

Closed
jmesserly opened this issue Feb 19, 2015 · 3 comments
Closed

more care around names generated into JS #60

jmesserly opened this issue Feb 19, 2015 · 3 comments
Assignees
@jmesserly

Comments

@jmesserly
Copy link
Contributor

there's some TODOs about this, but the code generally needs to be more careful about the names it emits into JS. e.g. things like avoid keywords or other names we don't want to shadow.
@jmesserly jmesserly added the js label Feb 19, 2015
@jmesserly
Copy link
Contributor Author

fwiw, it looks like js_ast (#61) offers some help w.r.t. names

@jmesserly
Copy link
Contributor Author

we saw another case of this: function as a local. I think js_ast is smart enough to rename properties away from invalid identifiers, but not locals

@jmesserly jmesserly self-assigned this Mar 19, 2015
@jmesserly
Copy link
Contributor Author

fix for this in the works

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jmesserly jmesserly

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jmesserly