More cases of doubled parentheses and exemptions for equality

Author: oprypin

lib/src/rules/unnecessary_parenthesis.dart

@@ -136,8 +136,11 @@ class _Visitor extends SimpleAstVisitor<void> {
         parent is InterpolationExpression ||
         (parent is ArgumentList && parent.arguments.length == 1) ||
         (parent is IfStatement && node == parent.condition) ||
+        (parent is IfElement && node == parent.condition) ||
         (parent is WhileStatement && node == parent.condition) ||
-        (parent is IfElement && node == parent.condition)) {
+        (parent is DoStatement && node == parent.condition) ||
+        (parent is SwitchStatement && node == parent.expression) ||
+        (parent is SwitchExpression && node == parent.expression)) {
       rule.reportLint(node);
       return;
     }
@@ -170,7 +173,8 @@ class _Visitor extends SimpleAstVisitor<void> {
       if (parent is AssignmentExpression ||
           parent is VariableDeclaration ||
           parent is ReturnStatement ||
-          parent is YieldStatement) {
+          parent is YieldStatement ||
+          parent is ConstructorFieldInitializer) {
         return;
       }
     }

test_data/rules/unnecessary_parenthesis.dart

@@ -142,20 +142,32 @@ main() async {
   var a3 = (1 + 1); // LINT
 }
 
-bool test() {
+bool testTernaryAndEquality() {
   if ((1 == 1 ? true : false)) // LINT
   {
-    return true;
+    return (1 != 1); // OK
   } else if ((1 == 1 ? true : false)) // LINT
   {
-    return false;
+    return (1 > 1); // LINT
   }
-  if ((1 == 1)) // LINT
+  while ((1 == 1)) // LINT
   {
-    return (1 != 1); // OK
-  } else {
-    return (1 > 1); // LINT
+    print('');
   }
+  switch ((5 == 6)) // LINT
+  {
+    case true:
+      return false;
+    default:
+      return true;
+  }
+}
+
+class TestConstructorFieldInitializer {
+  bool _x, _y;
+  TestConstructorFieldInitializer()
+      : _x = (1 == 2), // OK
+        _y = (true && false); // LINT
 }
 
 int test2() => (1 == 1 ? 2 : 3); // OK