stop discarding futures

Author: pq

analysis_options.yaml

@@ -39,6 +39,7 @@ linter:
 #    - close_sinks # https://github.com/dart-lang/linter/issues/268
     - comment_references
     - directives_ordering
+    - discarded_futures
     - invariant_booleans
     - join_return_with_assignment
 #    - lines_longer_than_80_chars # under review (see #1068)

tool/checks/driver.dart

@@ -20,10 +20,10 @@ import 'package:path/path.dart' as path;
 
 import 'rules/visit_registered_nodes.dart';
 
-void main() {
+Future<void> main() async {
   var rules =
       path.normalize(io.File(path.join('lib', 'src', 'rules')).absolute.path);
-  Driver([VisitRegisteredNodes()]).analyze([rules]);
+  await Driver([VisitRegisteredNodes()]).analyze([rules]);
 }
 
 class Driver {

tool/grind.dart

@@ -10,7 +10,9 @@ import 'doc.dart';
 import 'rule.dart';
 
 @Deprecated('To be removed')
-void main(List<String> args) => grind(args);
+Future<void> main(List<String> args) async {
+  await grind(args);
+}
 
 Iterable<String> get sourcePaths => sources.map((dir) => dir.path);
 
@@ -26,10 +28,10 @@ Iterable<FileSystemEntity> get sources => existingSourceDirs.expand((dir) {
     });
 
 @Task('Generate lint rule docs.')
-void docs() {
+Future<void> docs() async {
   var args = context.invocation.arguments;
   var dir = args.getOption('dir');
-  generateDocs(dir);
+  await generateDocs(dir);
 }
 
 @Task('Format linter sources.')