Skip to content

Commit 7e96773

Browse files
committed
change the ordering of the concatenated kernel files to be topological instead of reverse topological, see dart-lang/sdk#37533
1 parent d14a8bb commit 7e96773

File tree

4 files changed

+8
-3
lines changed

4 files changed

+8
-3
lines changed

build_vm_compilers/CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
## 1.0.2
2+
3+
- Fix kernel concat ordering to be topological instead of reverse
4+
topological.
5+
16
## 1.0.1
27

38
- Allow analyzer version 0.37.0.

build_vm_compilers/lib/src/vm_entrypoint_builder.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ https://github.com/dart-lang/build/blob/master/docs/faq.md#how-can-i-resolve-ski
6464

6565
var transitiveKernelModules = [
6666
module.primarySource.changeExtension(vmKernelModuleExtension)
67-
].followedBy(transitiveModules.map(
67+
].followedBy(transitiveModules.reversed.map(
6868
(m) => m.primarySource.changeExtension(vmKernelModuleExtension)));
6969
var appContents = <int>[];
7070
for (var dependencyId in transitiveKernelModules) {

build_vm_compilers/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
name: build_vm_compilers
2-
version: 1.0.1
2+
version: 1.0.2
33
description: Builder implementations wrapping Dart VM compilers.
44
author: Dart Team <[email protected]>
55
homepage: https://github.com/dart-lang/build/tree/master/build_vm_compilers

build_vm_compilers/test/vm_kernel_integration_test.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,6 @@ void printAsync() async {
8282

8383
expect(runResult.exitCode, 0, reason: runResult.stderr as String);
8484
expect(runResult.stdout, 'before\nrunning\nafter\n');
85-
}, skip: 'https://github.com/dart-lang/sdk/issues/34852');
85+
});
8686
});
8787
}

0 commit comments

Comments
 (0)