Skip to content

Commit f54915e

Browse files
committed
Fixes #3212. Fix the new roll failures. Add issue numbers
1 parent 53ac385 commit f54915e

10 files changed

+13
-10
lines changed

LanguageFeatures/Enhanced-Enum/grammar_A10_t04.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
/// static setter with the name `values=`, and its argument is not a supertype of
1414
/// the generated member `values`.
1515
/// @author [email protected]
16-
/// @issue 48387
16+
/// @issue 48387, 60821
1717
1818
import '../../Utils/expect.dart';
1919

LanguageFeatures/Extension-types/static_analysis_extension_types_A03_t02.dart

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,6 @@ extension type ET7(int id) {
7070

7171
extension type ET8(int id) {
7272
// ^^
73-
// [analyzer] unspecified
7473
// [cfe] unspecified
7574
static void set id(int v) {}
7675
// ^^

LanguageFeatures/Extension-types/static_analysis_extension_types_A30_t01.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
/// declares an instance setter with the same basename as the representation
1111
/// variable but with a not compatible type
1212
/// @author [email protected]
13-
/// @issue 53489
13+
/// @issue 53489, 58579
1414
1515
import '../../Utils/expect.dart';
1616

LanguageFeatures/Extension-types/static_analysis_extension_types_A30_t02.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
/// declares an instance setter with the same basename as the instance getter
1111
/// but with an incompatible type
1212
/// @author [email protected]
13-
/// @issue 53489
13+
/// @issue 53489, 58579
1414
1515
import '../../Utils/expect.dart';
1616

LanguageFeatures/Extension-types/static_analysis_extension_types_A30_t03.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
/// declares a static setter with the same basename as the static getter but
1111
/// with an incompatible type
1212
/// @author [email protected]
13-
/// @issue 53489
13+
/// @issue 53489, 58579
1414
1515
import '../../Utils/expect.dart';
1616

LanguageFeatures/Extension-types/static_analysis_member_invocation_A06_t04.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313
/// @description Checks that an instance getter doesn't preclude an instance
1414
/// setter and vice versa.
1515
/// @author [email protected]
16+
/// @issue 58579
1617
1718
import '../../Utils/expect.dart';
1819

LanguageFeatures/Extension-types/static_analysis_member_invocation_A08_t05.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@
1414
///
1515
/// @description Checks that a getter doesn't preclude a setter and vice versa.
1616
/// @author [email protected]
17+
/// @issue 58579
1718
1819
import '../../Utils/expect.dart';
1920

TypeSystem/flow-analysis/promotion_switch_A03_t01.dart

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,6 +81,4 @@ main() {
8181
test6(1);
8282
test6("one");
8383
test6(null);
84-
85-
test22("");
8684
}

TypeSystem/flow-analysis/promotion_switch_A04_t02.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ test3(Object? x) {
3535
switch (x) {
3636
case num v:
3737
x.expectStaticType<Exactly<num>>();
38-
case int _:
38+
case int _: // ignore: unreachable_switch_case
3939
x = 3.14;
4040
x.expectStaticType<Exactly<num>>();
4141
case _:
@@ -48,7 +48,7 @@ test3(Object? x) {
4848
test4(Object? x) {
4949
var y = switch (x) {
5050
num _ => x.expectStaticType<Exactly<num>>(),
51-
int v when (x = 3.14) > 0 => x.expectStaticType<Exactly<num>>(),
51+
int v when (x = 3.14) > 0 => x.expectStaticType<Exactly<num>>(), // ignore: unreachable_switch_case
5252
_ => x.expectStaticType<Exactly<Object?>>()
5353
};
5454
x.expectStaticType<Exactly<Object?>>();

TypeSystem/flow-analysis/reachability_switch_expression_A05_t01.dart

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,11 +18,15 @@
1818
/// @author [email protected]
1919
/// @issue 60677
2020
21-
main() {
21+
test() {
2222
late int i;
2323
var x = switch (42) {
2424
String _ => i = 42,
2525
_ => 0
2626
};
2727
i; // Possibly assigned, see https://github.com/dart-lang/sdk/issues/60677
2828
}
29+
30+
main() {
31+
print(test);
32+
}

0 commit comments

Comments
 (0)