Invalid test: LanguageFeatures/Set-literals/non_constant_set_literals_A02_t01.dart

[bwilkerson]

On line 47 a constant set is created that contains duplicate elements, but the line is not marked as expecting an error. Either the duplicate elements should be removed or the line should be annotated.

[sgrekhov]

@bwilkerson, according to the feature specification

Let e1 … en be the constant element expressions of s in source order, and let v1 … vn be their respective constant values. Evaluation of s creates an unmodifiable object implementing Set with v1 … vn as elements, except that if any of v1 … vn are equal, only the first value of such equal values is included.

So, according to the above, I believe, that it is not an error. If there are duplicating elements, then, only the first one of them should be taken.

[lrhn]

I've removed that sentence now. It's obsolete because two lines above that is says:

It is a compile-time error if any two of the values are equal according to ==.

(There are also rules disallowing the elements from overriding Object.operator==.)