Skip to content

Add use_string_in_part_of_directives #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
srawlins opened this issue Sep 14, 2022 · 4 comments · Fixed by dart-archive/lints#136
Closed

Add use_string_in_part_of_directives #781

srawlins opened this issue Sep 14, 2022 · 4 comments · Fixed by dart-archive/lints#136
Labels
lints-proposal package:lints should-have-a-dart-fix

Comments

@srawlins
Copy link
Member

I hereby propose we add use_string_in_part_of_directives.

  • The rule is part of Effective Dart.
  • The language team is considering banning the old syntax in a future version of Dart.
@devoncarew
Copy link
Member

As part of core? recommended?

@devoncarew devoncarew changed the title Add use_string_in_part_of_directives Add use_string_in_part_of_directives Feb 22, 2023
@srawlins
Copy link
Member Author

I propose for core.

@natebosch
Copy link
Member

yes, I vote core. If we could do it for free we'd probably eliminate non-string directives at the language level.

@devoncarew
Copy link
Member

Approved for core.

@devoncarew devoncarew mentioned this issue Jun 20, 2023
Merged
1 task
@mosuem mosuem transferred this issue from dart-archive/lints Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lints-proposal package:lints should-have-a-dart-fix
Projects
Lints Triage
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

update core and recommended from the recent review dart-archive/lints
5 participants
@pq @srawlins @devoncarew @natebosch @mosuem