Skip to content

Remove to-be-deprecated rules iterable_contains_unrelated_type and list_remove_unrelated_type #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
srawlins opened this issue May 15, 2023 · 5 comments · Fixed by dart-archive/lints#136

Comments

@srawlins
Copy link
Member

These two rules will be deprecated (in dart-lang/sdk#58958) in favor of collection_methods_unrelated_type, which I'd also like to add to package:lints (#787).

@devoncarew
Copy link
Member

What SDK version would the rules be deprecated in (and the new rule be available)?

@srawlins
Copy link
Member Author

srawlins commented May 15, 2023

The old rules will be deprecated in Dart 3.1 at the earliest. The new rule is available in Dart 2.19.0.

I'm not sure whether the right practice is to deprecate (which results in new diagnostics in analysis_options.yaml files) first or to remove from package:lints first.

@devoncarew
Copy link
Member

Hmm, from a previous discussion in this repo, I believe that the deprecations wouldn't show as diagnostics for users? Since the user's analysis options file would reference this one. So we likely have a freer hand wrt timing here (esp. as this package already has a lower bounds of 3.0.0-417).

@srawlins
Copy link
Member Author

The rules are now deprecated and should be removed from this repo.

@devoncarew
Copy link
Member

Removals approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants