Misc cleanup

Author: parlough

lib/context.dart

@@ -9,7 +9,7 @@ import 'dart:async';
 import 'services/dartservices.dart';
 
 abstract class Context {
-  List<AnalysisIssue> issues = [];
+  final List<AnalysisIssue> issues = [];
 
   String get focusedEditor;
 

lib/core/keys.dart

@@ -141,7 +141,7 @@ String makeKeyPresentable(String key) {
 
 bool isMac() => _isMac;
 
-final Map _codeMap = {
+const Map _codeMap = {
   KeyCode.ZERO: '0',
   KeyCode.ONE: '1',
   KeyCode.TWO: '2',
@@ -234,7 +234,7 @@ final Map _codeMap = {
   KeyCode.SHIFT: '', //
 };
 
-final Map _unicodeMac = {
+const Map _unicodeMac = {
   'macctrl': '\u2303',
   'alt': '\u2325',
   'shift': '\u21E7',

lib/dialogs.dart

@@ -48,9 +48,9 @@ class AboutDialog extends DDialog {
 }
 
 class SharingDialog extends DDialog {
-  final String home = 'dartpad.dev';
-  final String _dartThumbnail = 'pictures/embed-dart.png';
-  final String _htmlThumbnail = 'pictures/embed-html.png';
+  static const String home = 'dartpad.dev';
+  static const String _dartThumbnail = 'pictures/embed-dart.png';
+  static const String _htmlThumbnail = 'pictures/embed-html.png';
   final GistContainer gistContainer;
   final GistController gistController;
 

lib/documentation.dart

@@ -71,7 +71,7 @@ class DocHandler {
         if (a is AnchorElement) a.target = 'docs';
       }
       for (final h in docPanel.querySelectorAll('h1')) {
-        h.classes.add('type-${docResult.entitykind}');
+        h.classes.add('type-${docResult.entityKind}');
       }
     });
   }
@@ -109,7 +109,7 @@ class DocHandler {
         if (a is AnchorElement) a.target = 'docs';
       }
       for (final h in docPanel.querySelectorAll('h1')) {
-        h.classes.add('type-${docResult.entitykind}');
+        h.classes.add('type-${docResult.entityKind}');
       }
     });
   }
@@ -174,9 +174,9 @@ ${libraryName == null ? '' : apiLink}\n\n''';
 
 class _DocResult {
   final String html;
-  final String entitykind;
+  final String entityKind;
 
-  _DocResult(this.html, [this.entitykind]);
+  _DocResult(this.html, [this.entityKind]);
 }
 
 class InlineBracketsColon extends markdown.InlineSyntax {

lib/editing/editor.dart

@@ -148,7 +148,7 @@ class Position {
   final int line;
   final int char;
 
-  Position(this.line, this.char);
+  const Position(this.line, this.char);
 
   @override
   String toString() => '[$line,$char]';

lib/editing/editor_codemirror.dart

@@ -33,7 +33,7 @@ class CodeMirrorFactory extends EditorFactory {
   List<String> get themes => CodeMirror.THEMES;
 
   @override
-  Editor createFromElement(html.Element element, {Map options}) {
+  Editor createFromElement(html.Element element, {Map /*?*/ options}) {
     options ??= {
       'continueComments': {'continueLineComment': false},
       'autofocus': false,

lib/elements/analysis_results_controller.dart

@@ -20,9 +20,9 @@ class AnalysisResultsController {
     'error': ['issuelabel', 'error'],
   };
 
-  DElement flash;
-  DElement message;
-  DElement toggle;
+  final DElement flash;
+  final DElement message;
+  final DElement toggle;
   bool _flashHidden;
 
   final StreamController<AnalysisIssue> _onClickController =

lib/elements/counter.dart

@@ -6,12 +6,12 @@ import 'dart:html';
 
 /// Displays a counter that is only visible if the count is greater than zero.
 class Counter {
-  Counter(this.element);
-
   final SpanElement element;
 
   int _itemCount = 0;
 
+  Counter(this.element);
+
   void increment() {
     _itemCount++;
     element.text = '$_itemCount';

lib/elements/elements.css

@@ -186,7 +186,7 @@ button.close:hover {
   border-radius: 2px;
   background-color: #3a3a3a;
   padding: 8px 16px;
-  box-shadow: 3px 3px 4px 0px rgba(15, 14, 14, 0.7);
+  box-shadow: 3px 3px 4px 0 rgba(15, 14, 14, 0.7);
 }
 
 /* issues css */
@@ -276,8 +276,7 @@ button.close:hover {
   position: absolute;
   padding: 10px;
   background-color: #444;
-  border: 1px solid;
-  border-color: rgba(0, 0, 0, 0.5);
+  border: 1px solid rgba(0, 0, 0, 0.5);
   border-radius: 4px;
   box-shadow: rgba(255, 255, 255, 0.1) 0 0 0, rgba(0, 0, 0, 0.4) 0 1px 7px 0;
 
@@ -348,7 +347,7 @@ button.close:hover {
 /* style the <select> element */
 
 select {
-  -webkit-border-radius: 0px;
+  -webkit-border-radius: 0;
 
   color: #aaa;
   fill: #aaa;

lib/elements/elements.dart

@@ -105,12 +105,12 @@ class DButton extends DElement {
 
   DButton.close() : super.tag('button', classes: 'close');
 
-  ButtonElement get belement => element as ButtonElement;
+  ButtonElement get buttonElement => element as ButtonElement;
 
-  bool get disabled => belement.disabled;
+  bool get disabled => buttonElement.disabled;
 
   set disabled(bool value) {
-    belement.disabled = value;
+    buttonElement.disabled = value;
   }
 }
 
@@ -470,7 +470,7 @@ abstract class DDialog extends DElement {
   DElement content;
   DElement buttonArea;
 
-  DDialog({String title}) : super.tag('div') {
+  DDialog({String /*?*/ title}) : super.tag('div') {
     element.classes.addAll(['dialog', 'dialog-position']);
     setAttr('layout');
     setAttr('vertical');
@@ -580,7 +580,7 @@ class TabController {
 
 class TabElement extends DElement {
   final String name;
-  final Function onSelect;
+  final Function /*?*/ onSelect;
 
   TabElement(Element element, {this.name, this.onSelect}) : super(element);
 

lib/scss/shared.scss

@@ -57,7 +57,7 @@
 
 // Enabled features (e.g. null safety)
 #feature-message {
-  font-family: Roboto;
+  font-family: Roboto, sans-serif;
   font-weight: bolder;
 }
 

lib/sharing/exercise_metadata.dart

@@ -21,7 +21,7 @@ enum ExerciseMode {
   flutter,
 }
 
-final exerciseModeNames = <String, ExerciseMode>{
+const exerciseModeNames = <String, ExerciseMode>{
   'dart': ExerciseMode.dart,
   'html': ExerciseMode.html,
   'flutter': ExerciseMode.flutter,

lib/src/sample.dart

@@ -4,15 +4,15 @@
 
 library dart_pad.sample;
 
-final String dartCode = r'''
+const String dartCode = r'''
 void main() {
   for (int i = 0; i < 5; i++) {
     print('hello ${i + 1}');
   }
 }
 ''';
 
-final String dartCodeHtml = r'''
+const String dartCodeHtml = r'''
 import 'dart:html';
 
 void main() {
@@ -21,11 +21,11 @@ void main() {
 }
 ''';
 
-final String htmlCode = r'''
+const String htmlCode = r'''
 <h1 id="header"></h1>
 ''';
 
-final String cssCode = r'''
+const String cssCode = r'''
 body {
   display: flex;
   flex-direction: column;

lib/src/util.dart

@@ -31,7 +31,7 @@ class PermissiveNodeValidator implements NodeValidator {
 
 /// Text to be displayed to DartPad users. The associated title should be
 /// 'About DartPad' (or equivalent).
-final String privacyText = '''
+const String privacyText = '''
 DartPad is a free, open-source service to help developers learn about the Dart 
 language and libraries. Source code entered into DartPad may be sent to servers 
 running in Google Cloud Platform to be analyzed for errors/warnings, compiled