Don't put spaces in empty for loop clauses.

Fix #132.

BUG=#132
[email protected]

Review URL: https://chromiumcodereview.appspot.com//815423003

Author: munificent

CHANGELOG.md

@@ -1,6 +1,7 @@
 # 0.1.3
 
 * Split different operators with the same precedence equally (#130).
+* No spaces for empty for loop clauses (#132).
 
 # 0.1.2
 

lib/src/source_visitor.dart

@@ -753,36 +753,32 @@ class SourceVisitor implements AstVisitor {
     // The initialization clause.
     if (node.initialization != null) {
       visit(node.initialization);
-    } else {
-      if (node.variables == null) {
-        space();
-      } else {
-        // Indent split variables more so they aren't at the same level
-        // as the rest of the loop clauses.
-        _writer.indent(4);
+    } else if (node.variables != null) {
+      // Indent split variables more so they aren't at the same level
+      // as the rest of the loop clauses.
+      _writer.indent(4);
 
-        var declaration = node.variables;
-        visitDeclarationMetadata(declaration.metadata);
-        modifier(declaration.keyword);
-        visit(declaration.type, after: space);
+      var declaration = node.variables;
+      visitDeclarationMetadata(declaration.metadata);
+      modifier(declaration.keyword);
+      visit(declaration.type, after: space);
 
-        visitCommaSeparatedNodes(declaration.variables, between: () {
-          _writer.multisplit(space: true, nest: true);
-        });
+      visitCommaSeparatedNodes(declaration.variables, between: () {
+        _writer.multisplit(space: true, nest: true);
+      });
 
-        _writer.unindent(4);
-      }
+      _writer.unindent(4);
     }
 
     token(node.leftSeparator);
-    _writer.multisplit(nest: true, space: true);
 
     // The condition clause.
+    if (node.condition != null) _writer.multisplit(nest: true, space: true);
     visit(node.condition);
     token(node.rightSeparator);
 
     // The update clause.
-    if (node.updaters != null) {
+    if (node.updaters.isNotEmpty) {
       _writer.multisplit(nest: true, space: true);
       visitCommaSeparatedNodes(node.updaters,
           between: () => _writer.multisplit(nest: true, space: true));

test/regression/132.stmt

@@ -0,0 +1,10 @@
+>>>
+for (; i < words.length; i++) {
+  buffer.write(' ');
+  buffer.write(words[i]);
+}
+<<<
+for (; i < words.length; i++) {
+  buffer.write(' ');
+  buffer.write(words[i]);
+}

test/whitespace/for.stmt

@@ -7,10 +7,14 @@ for (var i = 0;i<100;i++) {
 for (var i = 0; i < 100; i++) {
   print(i);
 }
->>> empty clauses TODO(rnystrom): Is this what we want?
+>>> empty clauses
 for(;;);
 <<<
-for ( ; ; );
+for (;;);
+>>> empty initializer clause
+for (  ;   foo; bar) {}
+<<<
+for (; foo; bar) {}
 >>> whitespace
 for (var    file  in  files   ) {
   print(file);