Apply review feedback.

Author: munificent

example/format.dart

@@ -116,15 +116,12 @@ Future<void> _runTest(
   var actualText = actual.textWithSelectionMarkers;
   if (!testFile.isCompilationUnit) actualText += '\n';
 
-  String expectedText;
-  switch (formatTest) {
-    case UnversionedFormatTest():
-      expectedText = formatTest.output.code.textWithSelectionMarkers;
-    case VersionedFormatTest():
-      // Pick the newest style for the expectation.
-      expectedText =
-          formatTest.outputs.entries.last.value.code.textWithSelectionMarkers;
-  }
+  var output = switch (formatTest) {
+    UnversionedFormatTest(:var output) => output,
+    // Used the newest style for the expectation.
+    VersionedFormatTest(:var outputs) => outputs.values.last,
+  };
+  var expectedText = output.code.textWithSelectionMarkers;
 
   print('$path ${formatTest.input.description}');
   _drawRuler('before', pageWidth);

lib/src/testing/test_file.dart

@@ -358,7 +358,7 @@ final class VersionedFormatTest extends FormatTest {
   /// supported versions lower than the lowest key here, then the test is not
   /// run on those versions at all. These tests represent new syntax that isn't
   /// supported in later versions. For example, if the map has only a single
-  /// entry whose key is 3.8, then the test is skipped on 3.8, run at 3.8, and
+  /// entry whose key is 3.8, then the test is skipped on 3.7, run at 3.8, and
   /// should be valid at any higher version.
   ///
   /// If there are multiple entries in the map, they represent versions where

test/utils.dart

@@ -146,42 +146,33 @@ Future<void> testBenchmarks({required bool useTallStyle}) async {
 void _testFile(TestFile testFile) {
   group(testFile.path, () {
     for (var formatTest in testFile.tests) {
+      Map<Version, TestEntry> testedVersions;
       if (testFile.isTall) {
-        Map<Version, TestEntry> testedVersions;
-        switch (formatTest) {
-          case UnversionedFormatTest(:var output):
-            // This output is unversioned, so test at the lowest and highest
-            // supported versions. If it formats the same on those, we assume
-            // it does for all of the intermediate versions too.
-            testedVersions = {
-              _testedTallVersions.first: output,
-              _testedTallVersions.last: output,
-            };
-          case VersionedFormatTest(:var outputs):
-            testedVersions = _versionedTestEntries(outputs);
-        }
-
-        testedVersions.forEach((version, output) {
-          _runTestAtVersion(testFile, formatTest, output, version);
-        });
+        testedVersions = switch (formatTest) {
+          // This output is unversioned, so test at the lowest and highest
+          // supported versions. If it formats the same on those, we assume
+          // it does for all of the intermediate versions too.
+          UnversionedFormatTest(:var output) => {
+            _testedTallVersions.first: output,
+            _testedTallVersions.last: output,
+          },
+          VersionedFormatTest(:var outputs) => _versionedTestEntries(outputs),
+        };
       } else {
-        switch (formatTest) {
-          case UnversionedFormatTest(:var output):
-            _runTestAtVersion(
-              testFile,
-              formatTest,
-              output,
-              DartFormatter.latestShortStyleLanguageVersion,
-            );
-          case VersionedFormatTest(:var outputs):
-            // There is only one versioned short style test, for the legacy
-            // switch syntax. If the test is versioned, only run it on those
-            // versions and not anything later.
-            outputs.forEach((version, output) {
-              _runTestAtVersion(testFile, formatTest, output, version);
-            });
-        }
+        testedVersions = switch (formatTest) {
+          UnversionedFormatTest(:var output) => {
+            DartFormatter.latestShortStyleLanguageVersion: output,
+          },
+          // There is only one versioned short style test, for the legacy
+          // switch syntax. If the test is versioned, only run it on those
+          // versions and not anything later.
+          VersionedFormatTest(:var outputs) => outputs,
+        };
       }
+
+      testedVersions.forEach((version, output) {
+        _runTestAtVersion(testFile, formatTest, output, version);
+      });
     }
   });
 }