Change executable name to dartfmt

[sethladd]

Just a bit confusing... any chance we can unify the names?

[munificent]

Yes, I'll change the executable name to dartfmt once the SDK is running the new formatter code. I'm less concerned about the names shadowing on the PATH if they'll be running at least approximately the same application.

[seaneagan]

I think @sethladd was wanting to unify the package (dart_style) with the executable name (dartformat), no? That would be my preference, any of dart_format, dartformat, dartfmt SGTM. There's a parallel discussion going on over in dart_lint.

[sethladd]

I can't remember why we decided to use dart_style and dartformat (two different names).

We recently discussed this, and we decided not to have two different tool names, and just have one tool and one name: dartfmt.

So... should we rename this repo?

[pq]

The decision we arrived at over in dart_lint land was in fact to change that package to the more general linter with the expectation that it was already scoped by dartlang and publang for repo and package respectively. If we follow that lead, why not call this simply formatter?

[pq]

As for the dartfmt legacy, that's my bad... But can't we just make it go away? I doubt if many users would be affected since I'm guessing they mainly invoke it from a tool (such as DartEditor) and so wouldn't know the difference...

[sethladd]

Sublime uses (used?) dartfmt. We don't know how many people have integrated the dartfmt script (because we don't track adoption of our tools). We have to assume that removing it from the SDK is a breaking change.

[munificent]

I can't remember why we decided to use dart_style and dartformat (two different names).

I initially expected it to contain more than just the formatter: stuff like the linter, etc.

After talking about it with @pq, he decided to put the linter in a separate package, but by then the name dart_style was already in use. Since then, we have had a bit of discussion about sharing code between the linter and the formatter, so I'm still wondering if it makes sense to unify those packages.

[seaneagan]

@munificent I filed dart-lang/sdk#57276 for the suggestion from @pq above to rename this package/repo given it's tighter focus after the linter package was split out, since that was not addressed here.