Skip to content

dartfmt should fix formatting issues reported by Pub website / pana package #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cedx opened this issue May 24, 2019 · 1 comment
Closed

Comments

@cedx
Copy link

cedx commented May 24, 2019

Pub website has started to lower the score of packages with some formatting issues.

Me, and probably a lot of developers, will not change their coding style just because the Dart team has decided that our code was not properly formatted.

So, dartfmt should fix these errors in order to help package publishers to meet the new requirements of Pub website / pana analyzer.

See: dart-lang/pub-dev#2322

@natebosch
Copy link
Member

The pub-dev issue calls out braces around line-wrapped conditional bodies and included links to issues in this repo discussing it. I don't see other specific questions in that thread.

I reopened #664 to start a discussion about whether we can add a --fix flag for that one specifically. If there are other formatting issues that are checked by pana that you believe would fit as a --fix please open specific issues for them - a blanket issue isn't actionable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants