Skip to content

dartdoc should not use computeNode() #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcollins-g opened this issue Apr 14, 2017 · 2 comments
Closed

dartdoc should not use computeNode() #1375

jcollins-g opened this issue Apr 14, 2017 · 2 comments
Labels
P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable

Comments

@jcollins-g
Copy link
Contributor

@scheglov Konstantin, can you explain more about why using computeNode() is a bad idea? Dartdoc's instances of it seemed fairly benign at first glance to me.

@jcollins-g jcollins-g added type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable P3 A lower priority bug or feature request labels Apr 14, 2017
@scheglov
Copy link
Contributor

I don't remember the clincher, but here are some idea.
@bwilkerson might remember more ideas.

  1. There is no way for computeNode() to guarantee that it will read the same content of a file as the one which was used to create the element.

  2. When you call computeNode(), it has to perform full resolution, even if the client does not care about resolution of the full file, with method bodies.

  3. It's a bad API - it mixes elements and AST nodes.

@srawlins
Copy link
Member

srawlins commented Aug 9, 2020

Yay computeNode is no longer referenced or overridden.

@srawlins srawlins closed this as completed Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable
Projects
None yet
Development

No branches or pull requests

3 participants