Skip to content

dartdoc needs a better defined namespace lookup #1414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcollins-g opened this issue May 11, 2017 · 1 comment
Closed

dartdoc needs a better defined namespace lookup #1414

jcollins-g opened this issue May 11, 2017 · 1 comment
Labels
P2 A bug or feature request we're likely to work on

Comments

@jcollins-g
Copy link
Contributor

Part of #1412 and other odd behaviors of dartdoc in some edge cases is because dartdoc currently has a very hacky way of looking up names for the global namespace. #1390 basically refined the hack and made it actually work in a majority of cases so we could ship something functional with canonicalization, but there are still edge cases where it doesn't work. Particularly, it doesn't work for FQNs based on imports where libraries are renamed, there are bugs with inheritance and documentation inheritance, etc.

Dartdoc should have a lookup method in ModelElement where we can pass strings in, and have that traverse Dartdoc's structure to determine what object is relevant directly. Then we can jettison the table building/searching hack and behavior will be more consistent.

@jcollins-g jcollins-g added the P2 A bug or feature request we're likely to work on label May 11, 2017
@srawlins
Copy link
Member

We're removing the global namespace lookup, switching to use @docImport via analyzer. CC @kallentu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on
Projects
None yet
Development

No branches or pull requests

2 participants