Skip to content

macro implementation doesn't guarantee detection of templates before attempting to apply them #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcollins-g opened this issue May 17, 2017 · 2 comments
Labels
P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug

Comments

@jcollins-g
Copy link
Contributor

jcollins-g commented May 17, 2017

Even the line here: https://github.com/dart-lang/dartdoc/blob/master/lib/dartdoc.dart#L180 only changes the order in which things are loaded. The unfortunately named _rawDocs are cached by ModelElement's documentation so after this initial pass we'll never see the templates again.

This has always been a problem, but the canonicalization overhaul made this worse because before #1368 we usually recreated ModelElements frequently enough to cloak this (which caused its own problems). Fix with multiple passes or changing how templates work to make them no longer inline (but sourced from a separate file).

Lower priority only because macros don't seem to be in heavy use yet.

@jcollins-g jcollins-g added the P3 A lower priority bug or feature request label May 17, 2017
@jcollins-g
Copy link
Contributor Author

Moving to P2 because AFAICT there isn't even a warning when this happens; can demote to P3 if we at least warn on macros not being found.

@jcollins-g jcollins-g added P2 A bug or feature request we're likely to work on and removed P3 A lower priority bug or feature request labels May 22, 2017
@srawlins srawlins added type-enhancement A request for a change that isn't a bug P3 A lower priority bug or feature request and removed P2 A bug or feature request we're likely to work on labels Jul 19, 2024
@srawlins
Copy link
Member

Closing this as stale. At least flutter has a good system for warning on un-replaced macros.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants