Skip to content

Recent change to SDK breaks dartdoc assertions #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jcollins-g opened this issue Sep 21, 2017 · 1 comment
Closed

Recent change to SDK breaks dartdoc assertions #1505

jcollins-g opened this issue Sep 21, 2017 · 1 comment
Assignees
Labels
P0 A serious issue requiring immediate resolution

Comments

@jcollins-g
Copy link
Contributor

Detected in bots and in 2.0.0-dev-1.0.

documenting Dart SDK
 warning: unresolved doc reference [apply], from dart-js: (file:///usr/local/google/home/jcollins/dart/all_sdks/2.0.0-dev.1.0/lib/js/dart2js/js_dart2js.dart:88:9)
generating docs for library dart:async from async.dart...
Generation failed: 'package:dartdoc/src/model.dart': Failed assertion: line 3038 pos 12: '!name.isEmpty ||
        (this.element is TypeDefiningElement &&
            (this.element as TypeDefiningElement).type.name == "dynamic")': is not true.
dart:core                                                     _AssertionError._throwNew
package:dartdoc/src/model.dart 3038:12                        ModelElement._calculateLinkedName
package:dartdoc/src/model.dart 2744:21                        ModelElement.linkedName
package:dartdoc/src/element_type.dart 43:25                   ElementType.linkedName
package:dartdoc/src/element_type.dart 129:26                  ElementType.createLinkedReturnTypeName
package:dartdoc/src/model.dart 2034:44                        Method.linkedReturnType
dart:mirrors                                                  _LocalInstanceMirror.getField
package:mustache4dart/mustache_context.dart 335:19            _ObjectReflectorDeclaration.value
package:mustache4dart/mustache_context.dart 264:24            _ObjectReflector.[]
package:mustache4dart/mustache_context.dart 144:26            _MustacheContext._getActualValue
package:mustache4dart/mustache_context.dart 105:13            _MustacheContext._getMustachContext
package:mustache4dart/mustache_context.dart 101:12            _MustacheContext._getContextForKey
package:mustache4dart/mustache_context.dart 74:18             _MustacheContext._getInThisOrParent
package:mustache4dart/mustache_context.dart 70:12             _MustacheContext.[]
package:mustache4dart/src/tokens.dart 163:18                  _ExpressionToken.apply
package:mustache4dart/src/tokens.dart 40:18                   Token.call
package:mustache4dart/src/tmpl.dart 101:20                    _Template._write
package:mustache4dart/src/tmpl.dart 76:5                      _Template.call
package:mustache4dart/src/mustache.dart 11:64                 render
package:mustache4dart/src/tokens.dart 205:16                  _PartialToken.apply
package:mustache4dart/src/tokens.dart 280:57                  _StartSectionToken.apply.<fn>.<fn>
package:mustache4dart/src/tokens.dart 303:8                   _StartSectionToken.forEachUntilEndSection
package:mustache4dart/src/tokens.dart 280:9                   _StartSectionToken.apply.<fn>
dart:core                                                     Iterable.forEach
package:mustache4dart/src/tokens.dart 279:11                  _StartSectionToken.apply
package:mustache4dart/src/tokens.dart 293:53                  _StartSectionToken.apply.<fn>
package:mustache4dart/src/tokens.dart 303:8                   _StartSectionToken.forEachUntilEndSection
package:mustache4dart/src/tokens.dart 293:5                   _StartSectionToken.apply
package:mustache4dart/src/tokens.dart 40:18                   Token.call
package:mustache4dart/src/tmpl.dart 101:20                    _Template._write
package:mustache4dart/src/tmpl.dart 76:5                      _Template.call
package:dartdoc/src/html/html_generator_instance.dart 304:30  HtmlGeneratorInstance._build
package:dartdoc/src/html/html_generator_instance.dart 205:5   HtmlGeneratorInstance.generateClass
package:dartdoc/src/html/html_generator_instance.dart 106:9   HtmlGeneratorInstance._generateDocs
package:dartdoc/src/html/html_generator_instance.dart 47:7    HtmlGeneratorInstance.generate
package:dartdoc/src/html/html_generator.dart 74:22            HtmlGenerator.generate
package:dartdoc/dartdoc.dart 187:23                           DartDoc.generateDocs
../../dartdoc/bin/dartdoc.dart 200:44                         main.<fn>
package:stack_trace                                           Chain.capture
../../dartdoc/bin/dartdoc.dart 199:9                          main
===== asynchronous gap ===========================
dart:async                                                    _Completer.completeError
package:dartdoc/src/html/html_generator_instance.dart 56:3    HtmlGeneratorInstance.generate
===== asynchronous gap ===========================
dart:async                                                    new Future.microtask
package:dartdoc/src/html/html_generator_instance.dart 43:27   HtmlGeneratorInstance.generate
package:dartdoc/src/html/html_generator.dart 74:22            HtmlGenerator.generate
package:dartdoc/dartdoc.dart 187:23                           DartDoc.generateDocs
===== asynchronous gap ===========================
dart:async                                                    new Future.microtask
package:dartdoc/dartdoc.dart 128:47                           DartDoc.generateDocs
../../dartdoc/bin/dartdoc.dart 200:44                         main.<fn>
===== asynchronous gap ===========================
dart:async                                                    new Future.microtask
../../dartdoc/bin/dartdoc.dart 199:26                         main.<fn>
package:stack_trace                                           Chain.capture
../../dartdoc/bin/dartdoc.dart 199:9                          main
@jcollins-g jcollins-g added the P0 A serious issue requiring immediate resolution label Sep 21, 2017
@jcollins-g jcollins-g self-assigned this Sep 21, 2017
@jcollins-g
Copy link
Contributor Author

jcollins-g commented Sep 28, 2017

dart-lang/sdk@38bf70d

is the root cause, here. dartdoc does not handle anonymous typed functions well. While the code will continue outside checked mode, dartdoc doesn't generate right output without #1506.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 A serious issue requiring immediate resolution
Projects
None yet
Development

No branches or pull requests

1 participant