From e3add0c88e8d6a18cbfae663d555bbdc8fc09071 Mon Sep 17 00:00:00 2001
From: Sam Rawlins <srawlins@google.com>
Date: Wed, 3 Apr 2024 11:58:00 -0700
Subject: [PATCH] Remove a TODO in Accessor.characterLocation

I looked into `nonSynthetic` and it doesn't buy us anything here. Instead, we
can just rely on analyzer's `isSynthetic` to get the right location.
---
 lib/src/model/accessor.dart | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/lib/src/model/accessor.dart b/lib/src/model/accessor.dart
index d1e9aa250c..900a75358e 100644
--- a/lib/src/model/accessor.dart
+++ b/lib/src/model/accessor.dart
@@ -32,14 +32,9 @@ class Accessor extends ModelElement {
       [ExecutableMember? super.originalMember]);
 
   @override
-  CharacterLocation? get characterLocation {
-    if (element.nameOffset < 0) {
-      assert(element.isSynthetic, 'Invalid offset for non-synthetic element');
-      // TODO(jcollins-g): switch to [element.nonSynthetic] after analyzer 1.8
-      return enclosingCombo.characterLocation;
-    }
-    return super.characterLocation;
-  }
+  CharacterLocation? get characterLocation => element.isSynthetic
+      ? enclosingCombo.characterLocation
+      : super.characterLocation;
 
   @override
   ExecutableMember? get originalMember =>