Non-localized error description in ClientException

[jv-soares]

Hey guys this is rather a question than a feature request.

The problem im facing is that some ClientException errors sent to my crash reporting tool are unreadable and hard to group because they contain localized messages.

For instance, I see ClientException: Неможливо встановити з’єднання для передавання даних, бо триває виклик as an error message and i have no idea what it means.

By taking a quick look at cupertino_client.dart i could find how a ClientException is constructed using NSError.localizedDescription

static void _onComplete(URLSession session, URLSessionTask task, NSError? error) {
    final taskTracker = _tracker(task);
    if (error != null) {
      final exception = ClientException(error.localizedDescription.toString(), taskTracker.request.url);
...

so my question is: is it possible to use a non-localized description instead?

[brianquinlan]

@jv-soares I don't think that there is a non-localized user-friendly description. Would it be sufficient to provide a ClientException subclass that allows you to access the underlying NSError?

You'd probably want to extract error.code (e.g. -1003 for domain not found) and error.domain (e.g. 'NSURLErrorDomain').

The code would look something like:

try {
  client...
} on NSErrorClientException catch (e) {
  print(e.error.code);
} on ClientException catch(e) {
  // Handle ClientException as normal
} 

[brianquinlan]

I have a PR out that captures this idea: https://github.com/dart-lang/http/pull/1763/files

Notice how the stringification of the exception includes the error code and domain, which should be the same in across languages.