Skip to content

Docs for maxRedirects mention wrong exception #882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Hixie opened this issue Feb 25, 2023 · 0 comments · Fixed by #907
Closed

Docs for maxRedirects mention wrong exception #882

Hixie opened this issue Feb 25, 2023 · 0 comments · Fixed by #907
Assignees
@brianquinlan
Labels
package:http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@Hixie
Copy link

Hixie commented Feb 25, 2023

https://pub.dev/documentation/http/latest/http/BaseRequest/maxRedirects.html says

If this number is exceeded the BaseResponse future will signal a RedirectException. Defaults to 5.

...but it actually fires a ClientException, and there doesn't appear to be such a thing as a RedirectException.
@Hixie Hixie added package:http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) labels Feb 25, 2023
@brianquinlan brianquinlan self-assigned this Apr 3, 2023
@brianquinlan brianquinlan mentioned this issue Apr 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brianquinlan brianquinlan

Labels
package:http type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix maxRedirects documentation to mention ClientException brianquinlan/http
2 participants
@Hixie @brianquinlan