Skip to content

Fix Multipart support #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kevmoo opened this issue Jun 23, 2017 · 2 comments
Closed

Fix Multipart support #97

kevmoo opened this issue Jun 23, 2017 · 2 comments

Comments

@kevmoo
Copy link
Member

kevmoo commented Jun 23, 2017

CC @donny-dont

@donny-dont
Copy link

@nex3 do you have any idea where you want to go with the multipart support?

I was thinking maybe more of a builder sort of setup.

@nex3
Copy link
Member

nex3 commented Jun 24, 2017

That's a good question. Maybe just expose it as a separate constructor:

new Request.multipart(String method, url, List<MultipartFile> files,
    {Map<String, String> fields,
    Map<String, String> headers,
    Map<String, Object> context});

It's not orthogonal to the other utility constructors, but I don't see a great way to make that work unless we add a totally new type of body which doesn't seem ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants