Skip to content

[Records] Informal feature specification #2418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
itsjustkevin opened this issue Aug 19, 2022 · 10 comments
Closed

[Records] Informal feature specification #2418

itsjustkevin opened this issue Aug 19, 2022 · 10 comments
Assignees
Labels
records Issues related to records.

Comments

@itsjustkevin
Copy link

itsjustkevin commented Aug 19, 2022

[2022-09-14] Moved to accepted here.

In progress draft:
https://github.com/dart-lang/language/blob/master/working/0546-patterns/records-feature-specification.md

@munificent
Copy link
Member

I'm definitely writing the proposal, but it's usually @eernstg who translates that into the official language spec.

@itsjustkevin
Copy link
Author

@munificent does @eernstg typically do this for all language features or just a specific subset?

@eernstg
Copy link
Member

eernstg commented Aug 23, 2022

I'm typically the one who is updating the language specification, and at times I also create proposals for updates to feature specifications where I wasn't the author in the first place (e.g., if some murky corner case comes up and we need to make adjustments to an existing feature spec).

@itsjustkevin
Copy link
Author

@eernstg thank you for clarifying. For template purposes when creating projects, do you mind if I assign you as the default owner for these tasks?

@eernstg
Copy link
Member

eernstg commented Aug 23, 2022

No problem, but it might be more in line with reality if the assignee isn't chosen by default. For instance, the records proposal is very much driven by @munificent and I haven't done anything other than commenting on small things along the way. ;-)

@munificent
Copy link
Member

Yeah, usually the way this works (as I understand it) is that the feature designer (me in this case) owns defining it in the informal specification until the feature gets accepted. Then, in parallel with the implementations or after, @eernstg adds the feature to the language specification.

If this issue is tracking "design the feature", then I own it. If it's tracking, "add the feature to the Dart language specific doc", then Erik probably does.

@munificent munificent added the records Issues related to records. label Aug 25, 2022
@mit-mit
Copy link
Member

mit-mit commented Aug 26, 2022

Let's make this about the feature spec; that's the one that most eng. work is gated by.

@mit-mit mit-mit changed the title [Records] Write the spec [Records] Informal feature specification Aug 26, 2022
@nuritzi
Copy link

nuritzi commented Nov 1, 2022

I'm trying to clean up the GitHub Project tracking this feature work. Are we ok to close out this issue as complete @eernstg and @munificent?

@eernstg
Copy link
Member

eernstg commented Nov 1, 2022

@munificent
Copy link
Member

munificent commented Nov 4, 2022

Yes, I think it's fine to close this. There two remaining issues that are relevant to specifying records, #2578 and #2503. But resolving those will likely not involve changes to the actual records proposal itself since inference and type promotion are specified elsewhere.

Let's call it done! 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
records Issues related to records.
Projects
None yet
Development

No branches or pull requests

5 participants