[native_assets_cli] Cleanup protocol pre 1.7.0 (#2009)

Remove all support for protocol pre-1.7:

* Remove all dry run!
* Remove the non-hierarchical config

Closes: #1485

The minimum SDK constraint on `native_assets_cli` has been bumped to 3.7, and Dart and Flutter 3.8.0 dev contain a builder that emits at least 1.7. So, `native_asset_cli` usages shouldn't start failing.

Once this change rolls into dartdev and flutter_tools, users will be see failing hooks with old `native_assets_cli` deps. They should `pub upgrade`. This is expected behavior when depending on an experimental feature.

Author: dcharkes

pkgs/native_assets_builder/lib/src/build_runner/build_runner.dart

@@ -135,7 +135,7 @@ class NativeAssetsBuildRunner {
       final inputBuilder =
           inputCreator()
             ..config.setupShared(buildAssetTypes: buildAssetTypes)
-            ..config.setupBuild(dryRun: false, linkingEnabled: linkingEnabled)
+            ..config.setupBuild(linkingEnabled: linkingEnabled)
             ..setupBuildInput(metadata: metadata);
 
       final (buildDirUri, outDirUri, outDirSharedUri) = await _setupDirectories(

pkgs/native_assets_builder/lib/src/model/link_result.dart

@@ -4,8 +4,8 @@
 
 import 'package:native_assets_cli/native_assets_cli_internal.dart';
 
-/// The result of executing the link hooks in dry run mode from all packages in
-/// the dependency tree of the entry point application.
+/// The result of executing the link hooks from all packages in the dependency
+/// tree of the entry point application.
 abstract interface class LinkResult {
   /// All assets (produced by the build & link hooks) that have to be bundled
   /// with the app.

pkgs/native_assets_builder/test/test_data/native_dynamic_linking_test.dart

@@ -39,7 +39,7 @@ void main() async {
               outputDirectory: outputDirectory,
               outputDirectoryShared: outputDirectoryShared,
             )
-            ..config.setupBuild(dryRun: false, linkingEnabled: false)
+            ..config.setupBuild(linkingEnabled: false)
             ..config.setupShared(buildAssetTypes: [CodeAsset.type])
             ..config.setupCode(
               targetArchitecture: Architecture.current,

pkgs/native_assets_builder/test/test_data/transformer_test.dart

@@ -50,7 +50,7 @@ void main() async {
                 outputDirectory: outputDirectory,
                 outputDirectoryShared: outputDirectoryShared,
               )
-              ..config.setupBuild(dryRun: false, linkingEnabled: false)
+              ..config.setupBuild(linkingEnabled: false)
               ..config.setupShared(
                 buildAssetTypes: [CodeAsset.type, DataAsset.type],
               )

pkgs/native_assets_builder/test_data/native_add_version_skew/hook/build.dart

@@ -7,15 +7,15 @@ import 'package:native_assets_cli/native_assets_cli.dart';
 import 'package:native_toolchain_c/native_toolchain_c.dart';
 
 void main(List<String> arguments) async {
-  await build(arguments, (config, output) async {
-    final packageName = config.packageName;
+  await build(arguments, (input, output) async {
+    final packageName = input.packageName;
     final cbuilder = CBuilder.library(
       name: packageName,
       assetName: 'src/native_add_bindings_generated.dart',
       sources: ['src/native_add.c'],
     );
     await cbuilder.run(
-      config: config,
+      input: input,
       output: output,
       logger:
           Logger('')

pkgs/native_assets_builder/test_data/native_add_version_skew/pubspec.yaml

@@ -9,8 +9,8 @@ environment:
 
 dependencies:
   logging: ^1.1.1
-  native_assets_cli: ^0.9.0
-  native_toolchain_c: ^0.6.0
+  native_assets_cli: ^0.11.0
+  native_toolchain_c: ^0.8.0
 
 dev_dependencies:
   ffigen: ^8.0.2

pkgs/native_assets_builder/test_data/use_all_api/hook/build.dart

@@ -19,7 +19,6 @@ void main(List<String> args) async {
     // c. target config
     // c.1. per hook
     input.config.linkingEnabled; // build only
-    input.config.dryRun; // build only, deleted soon
     // c.2. per asset
     input.config.buildAssetTypes;
     input.config.code.linkModePreference;

pkgs/native_assets_cli/example/build/download_asset/tool/build.dart

@@ -83,7 +83,7 @@ BuildInput createBuildInput(
           outputDirectoryShared: outputDirectoryShared,
         )
         ..config.setupShared(buildAssetTypes: [CodeAsset.type])
-        ..config.setupBuild(dryRun: false, linkingEnabled: false)
+        ..config.setupBuild(linkingEnabled: false)
         ..config.setupCode(
           targetArchitecture: Architecture.fromString(architecture),
           targetOS: os,

pkgs/native_assets_cli/example/build/local_asset/hook/build.dart

@@ -19,13 +19,11 @@ Future<void> main(List<String> args) async {
     final packageName = input.packageName;
     final assetPath = input.outputDirectory.resolve(assetName);
     final assetSourcePath = input.packageRoot.resolveUri(packageAssetPath);
-    // ignore: deprecated_member_use
-    if (!input.config.dryRun) {
-      // Insert code that downloads or builds the asset to `assetPath`.
-      await File.fromUri(assetSourcePath).copy(assetPath.toFilePath());
 
-      output.addDependencies([assetSourcePath]);
-    }
+    // Insert code that downloads or builds the asset to `assetPath`.
+    await File.fromUri(assetSourcePath).copy(assetPath.toFilePath());
+
+    output.addDependencies([assetSourcePath]);
 
     output.assets.code.add(
       // TODO: Change to DataAsset once the Dart/Flutter SDK can consume it.
@@ -35,9 +33,7 @@ Future<void> main(List<String> args) async {
         file: assetPath,
         linkMode: DynamicLoadingBundled(),
         os: input.config.code.targetOS,
-        architecture:
-            // ignore: deprecated_member_use
-            input.config.dryRun ? null : input.config.code.targetArchitecture,
+        architecture: input.config.code.targetArchitecture,
       ),
     );
   });

pkgs/native_assets_cli/lib/src/api/build.dart

@@ -67,14 +67,12 @@ import '../validation.dart';
 ///     final packageName = input.packageName;
 ///     final assetPath = input.outputDirectory.resolve(assetName);
 ///     final assetSourcePath = input.packageRoot.resolveUri(packageAssetPath);
-///     if (!input.dryRun) {
-///       // Insert code that downloads or builds the asset to `assetPath`.
-///       await File.fromUri(assetSourcePath).copy(assetPath.toFilePath());
+///     // Insert code that downloads or builds the asset to `assetPath`.
+///     await File.fromUri(assetSourcePath).copy(assetPath.toFilePath());
 ///
-///       output.addDependencies([
-///         assetSourcePath,
-///       ]);
-///     }
+///     output.addDependencies([
+///       assetSourcePath,
+///     ]);
 ///
 ///     output.assets.code.add(
 ///       // TODO: Change to DataAsset once the Dart/Flutter SDK can consume it.

pkgs/native_assets_cli/lib/src/code_assets/c_compiler_config.dart

@@ -77,10 +77,7 @@ final class CCompilerConfig {
   ///
   /// The returned json can be used in [CCompilerConfig.fromJson] to
   /// obtain a [CCompilerConfig] again.
-  ///
-  /// If [deprecatedTopLevel], does not nest developerCommandPrompt.
-  // TODO: Remove deprecatedTopLevel once protocol 1.8.0 is no longer supported.
-  Map<String, Object> toJson({bool deprecatedTopLevel = false}) =>
+  Map<String, Object> toJson() =>
       {
         _arConfigKey: archiver.toFilePath(),
         _ccConfigKey: compiler.toFilePath(),
@@ -91,7 +88,7 @@ final class CCompilerConfig {
         if (_windows?.developerCommandPrompt?.arguments != null)
           _envScriptArgsConfigKeyDeprecated:
               _windows!.developerCommandPrompt!.arguments,
-        if (_windows != null && !deprecatedTopLevel)
+        if (_windows != null)
           _windowsConfigKey: {
             if (_windows.developerCommandPrompt != null)
               _developerCommandPromptConfigKey: {