[hooks_runner] Use dot shorthands

Author: dcharkes

pkgs/hooks_runner/analysis_options.yaml

@@ -11,3 +11,6 @@ linter:
     - prefer_expression_function_bodies
     - prefer_final_in_for_each
     - prefer_final_locals
+
+formatter:
+  trailing_commas: preserve

pkgs/hooks_runner/lib/src/build_runner/build_planner.dart

@@ -76,8 +76,8 @@ class NativeAssetsBuildPlanner {
     'BuildPlanner.packagesWithHook',
     arguments: {'hook': hook.toString()},
     () async => switch (hook) {
-      Hook.build => _packagesWithBuildHook ??= await _runPackagesWithHook(hook),
-      Hook.link => _packagesWithLinkHook ??= await _runPackagesWithHook(hook),
+      .build => _packagesWithBuildHook ??= await _runPackagesWithHook(hook),
+      .link => _packagesWithLinkHook ??= await _runPackagesWithHook(hook),
     },
   );
 
@@ -332,7 +332,8 @@ class PackageGraph {
 /// compilation. This enum holds static information about these hooks.
 enum Hook {
   link('link'),
-  build('build');
+  build('build')
+  ;
 
   final String _scriptName;
 

pkgs/hooks_runner/lib/src/build_runner/build_runner.dart

@@ -136,7 +136,7 @@ class NativeAssetsBuildRunner {
     required List<ProtocolExtension> extensions,
     required bool linkingEnabled,
   }) async => _timeAsync('BuildRunner.build', () async {
-    final planResult = await _makePlan(hook: Hook.build, buildResult: null);
+    final planResult = await _makePlan(hook: .build, buildResult: null);
     if (planResult.isFailure) {
       return planResult.asFailure;
     }
@@ -252,10 +252,7 @@ class NativeAssetsBuildRunner {
     Uri? resourceIdentifiers,
     required BuildResult buildResult,
   }) async => _timeAsync('BuildRunner.link', () async {
-    final planResult = await _makePlan(
-      hook: Hook.link,
-      buildResult: buildResult,
-    );
+    final planResult = await _makePlan(hook: .link, buildResult: buildResult);
     if (planResult.isFailure) return planResult.asFailure;
     final (buildPlan, packageGraph) = planResult.success;
     if (buildPlan.isEmpty) {
@@ -930,7 +927,7 @@ ${compileResult.stdout}
     if (input is BuildInput) {
       final planner = await _planner;
       final packagesWithLink = (await planner.packagesWithHook(
-        Hook.link,
+        .link,
       )).map((p) => p.name);
       for (final targetPackage
           in (output as BuildOutput).assets.encodedAssetsForLinking.keys) {
@@ -966,14 +963,14 @@ ${compileResult.stdout}
   _makePlan({required Hook hook, BuildResult? buildResult}) async =>
       _timeAsync('_makePlan', () async {
         switch (hook) {
-          case Hook.build:
+          case .build:
             final planner = await _planner;
             final planResult = await planner.makeBuildHookPlan();
             if (planResult.isFailure) {
               return planResult.asFailure;
             }
             return Success((planResult.success, planner.packageGraph));
-          case Hook.link:
+          case .link:
             final planner = await _planner;
             final planResult = await planner.makeLinkHookPlan();
             if (planResult.isFailure) {
@@ -1004,10 +1001,10 @@ ${e.message}''');
       return const Failure(HooksRunnerFailure.hookRun);
     }
     switch (hook) {
-      case Hook.build:
+      case .build:
         final buildInput = BuildInput(hookInputJson);
         return Success(buildInput);
-      case Hook.link:
+      case .link:
         final linkInput = LinkInput(hookInputJson);
         return Success(linkInput);
     }
@@ -1044,7 +1041,7 @@ ${e.message}''');
       return const Failure(HooksRunnerFailure.hookRun);
     }
     switch (hook) {
-      case Hook.build:
+      case .build:
         final output = BuildOutputMaybeFailure(hookOutputJson);
         switch (output) {
           case BuildOutput _:
@@ -1054,7 +1051,7 @@ ${e.message}''');
           case BuildOutputFailure _:
             return const Failure(HooksRunnerFailure.hookRun);
         }
-      case Hook.link:
+      case .link:
         final output = LinkOutputMaybeFailure(hookOutputJson);
         switch (output) {
           case LinkOutput _:

pkgs/hooks_runner/lib/src/locking/locking.dart

@@ -3,7 +3,7 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
-import 'dart:io' show Platform, pid;
+import 'dart:io' show FileLock, Platform, pid;
 import 'package:file/file.dart';
 
 import 'package:logging/logging.dart';
@@ -85,7 +85,7 @@ Future<T> _runUnderFileLock<T>(
   Logger? logger,
 }) async {
   if (!await file.exists()) await file.create(recursive: true);
-  final randomAccessFile = await file.open(mode: FileMode.write);
+  final randomAccessFile = await file.open(mode: .write);
   var printed = false;
   var errorFromCallback = false;
   final stopwatch = Stopwatch()..start();

pkgs/hooks_runner/test/build_runner/build_dependencies_test.dart

@@ -28,7 +28,7 @@ void main() async {
           logger,
           dartExecutable,
           capturedLogs: logMessages,
-          buildAssetTypes: [BuildAssetType.code],
+          buildAssetTypes: [.code],
         )).success;
         expect(
           logMessages.join('\n'),

pkgs/hooks_runner/test/build_runner/build_planner_test.dart

@@ -38,7 +38,7 @@ void main() async {
             fileSystem: const LocalFileSystem(),
           );
       final packagesWithHook = await nativeAssetsBuildPlanner.packagesWithHook(
-        Hook.build,
+        .build,
       );
       expect(packagesWithHook.length, 1);
       final buildPlan = await nativeAssetsBuildPlanner.makeBuildHookPlan();

pkgs/hooks_runner/test/build_runner/build_process_helper.dart

@@ -20,7 +20,7 @@ void main(List<String> args) async {
   final target = Target.fromString(args[1]);
 
   final logger = Logger('')
-    ..level = Level.ALL
+    ..level = .ALL
     ..onRecord.listen((event) => print(event.message));
 
   final targetOS = target.os;
@@ -43,13 +43,13 @@ void main(List<String> args) async {
           CodeAssetExtension(
             targetArchitecture: target.architecture,
             targetOS: targetOS,
-            macOS: targetOS == OS.macOS
+            macOS: targetOS == .macOS
                 ? MacOSCodeConfig(targetVersion: defaultMacOSVersion)
                 : null,
-            android: targetOS == OS.android
+            android: targetOS == .android
                 ? AndroidCodeConfig(targetNdkApi: 30)
                 : null,
-            linkModePreference: LinkModePreference.dynamic,
+            linkModePreference: .dynamic,
           ),
           DataAssetsExtension(),
         ],

pkgs/hooks_runner/test/build_runner/build_runner_asset_id_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:logging/logging.dart';
 import 'package:test/test.dart';
 
 import '../helpers.dart';
@@ -22,9 +21,9 @@ void main() async {
         final logMessages = <String>[];
         final result = await build(
           packageUri,
-          createCapturingLogger(logMessages, level: Level.SEVERE),
+          createCapturingLogger(logMessages, level: .SEVERE),
           dartExecutable,
-          buildAssetTypes: [BuildAssetType.code],
+          buildAssetTypes: [.code],
         );
         final fullLog = logMessages.join('\n');
         expect(result.isFailure, isTrue);
@@ -52,7 +51,7 @@ void main() async {
           packageUri,
           logger,
           dartExecutable,
-          buildAssetTypes: [BuildAssetType.code],
+          buildAssetTypes: [.code],
         );
         expect(result, isNotNull);
       }

pkgs/hooks_runner/test/build_runner/build_runner_build_output_format_test.dart

@@ -2,7 +2,6 @@
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
-import 'package:logging/logging.dart';
 import 'package:test/test.dart';
 
 import '../helpers.dart';
@@ -28,7 +27,7 @@ void main() async {
           final logMessages = <String>[];
           final result = await build(
             packageUri,
-            createCapturingLogger(logMessages, level: Level.SEVERE),
+            createCapturingLogger(logMessages, level: .SEVERE),
             dartExecutable,
             buildAssetTypes: [],
           );

pkgs/hooks_runner/test/build_runner/build_runner_caching_test.dart

@@ -34,7 +34,7 @@ void main() async {
           logger,
           dartExecutable,
           capturedLogs: logMessages,
-          buildAssetTypes: [BuildAssetType.code],
+          buildAssetTypes: [.code],
           userDefines: userDefines,
         )).success;
         expect(
@@ -78,7 +78,7 @@ void main() async {
           logger,
           dartExecutable,
           capturedLogs: logMessages,
-          buildAssetTypes: [BuildAssetType.code],
+          buildAssetTypes: [.code],
           userDefines: userDefines,
         )).success;
         final hookUri = packageUri.resolve('hook/build.dart');
@@ -128,7 +128,7 @@ void main() async {
           logger,
           dartExecutable,
           capturedLogs: logMessages,
-          buildAssetTypes: [BuildAssetType.code],
+          buildAssetTypes: [.code],
           userDefines: userDefines,
         )).success;
         expect(
@@ -156,7 +156,7 @@ void main() async {
           packageUri,
           logger,
           dartExecutable,
-          buildAssetTypes: [BuildAssetType.code],
+          buildAssetTypes: [.code],
         )).success;
         await expectSymbols(
           asset: CodeAsset.fromEncoded(result.encodedAssets.single),
@@ -175,7 +175,7 @@ void main() async {
           packageUri,
           logger,
           dartExecutable,
-          buildAssetTypes: [BuildAssetType.code],
+          buildAssetTypes: [.code],
         )).success;
 
         final cUri = packageUri.resolve('src/').resolve('native_add.c');
@@ -238,7 +238,7 @@ void main() async {
           packageUri,
           logger,
           dartExecutable,
-          buildAssetTypes: [BuildAssetType.code],
+          buildAssetTypes: [.code],
         )).success;
 
         final hookUri = packageUri.resolve('hook/build.dart');
@@ -272,7 +272,7 @@ void main() async {
           packageUri,
           logger,
           dartExecutable,
-          buildAssetTypes: [BuildAssetType.code],
+          buildAssetTypes: [.code],
           hookEnvironment: modifiedEnvKey == 'PATH'
               ? null
               : filteredEnvironment(
@@ -307,7 +307,7 @@ void main() async {
           packageUri,
           logger,
           dartExecutable,
-          buildAssetTypes: [BuildAssetType.code],
+          buildAssetTypes: [.code],
         )).success;
         expect(logMessages.join('\n'), contains('hook.dill'));
         expect(