Fix tests

Author: HosseinYousefi

pkgs/jni/test/global_env_test.dart

@@ -110,7 +110,8 @@ void run({required TestRunnerCallback testRunner}) {
                 integerClass,
                 "parseInt".toNativeChars(arena),
                 "(Ljava/lang/String;)I".toNativeChars(arena));
-            final args = toJValues(["hello"], allocator: arena);
+            final args = toJValues(["hello".toJString()..releasedBy(arena)],
+                allocator: arena);
             expect(
                 () => env.CallStaticIntMethodA(
                     integerClass, parseIntMethod, args),
@@ -171,7 +172,9 @@ void run({required TestRunnerCallback testRunner}) {
     final systemOut = using((arena) {
       final systemClass =
           env.FindClass("java/lang/System".toNativeChars(arena));
-      final outField = env.GetFieldID(systemClass, "out".toNativeChars(arena),
+      final outField = env.GetStaticFieldID(
+          systemClass,
+          "out".toNativeChars(arena),
           "Ljava/io/PrintStream;".toNativeChars(arena));
       env.DeleteGlobalRef(systemClass);
       return env.GetStaticObjectField(systemClass, outField);
@@ -210,9 +213,13 @@ void run({required TestRunnerCallback testRunner}) {
     using((arena) {
       final systemClass =
           env.FindClass("java/lang/System".toNativeChars(arena));
-      final outField = env.GetFieldID(systemClass, "out".toNativeChars(arena),
+      final outField = env.GetStaticFieldID(
+          systemClass,
+          "out".toNativeChars(arena),
           "Ljava/io/PrintStream;".toNativeChars(arena));
-      final errField = env.GetFieldID(systemClass, "err".toNativeChars(arena),
+      final errField = env.GetStaticFieldID(
+          systemClass,
+          "err".toNativeChars(arena),
           "Ljava/io/PrintStream;".toNativeChars(arena));
       final systemOut = env.GetStaticObjectField(systemClass, outField);
       final systemErr = env.GetStaticObjectField(systemClass, errField);

pkgs/jni/test/jobject_test.dart

@@ -49,7 +49,7 @@ void run({required TestRunnerCallback testRunner}) {
       jint.type,
       [],
     );
-    expect(intValue, equals(176));
+    expect(intValue, 176);
 
     // Release any JObject and JClass instances using `.release()` after use.
     // This is not strictly required since JNI objects / classes have
@@ -70,7 +70,7 @@ void run({required TestRunnerCallback testRunner}) {
 
     // Dart string is a copy, original object can be released.
     result.release();
-    expect(resultString, equals("1f"));
+    expect(resultString, "1f");
 
     // Also don't forget to release the class.
     integerClass.release();
@@ -119,7 +119,7 @@ void run({required TestRunnerCallback testRunner}) {
         bits += r % 2;
         r = (r / 2).floor();
       }
-      expect(jbc, equals(bits));
+      expect(jbc, bits);
     }
     random.release();
     longClass.release();
@@ -132,25 +132,23 @@ void run({required TestRunnerCallback testRunner}) {
       jint.type,
       [JValueShort(1234), JValueShort(1324)],
     );
-    expect(m, equals(1234 - 1324));
+    expect(m, 1234 - 1324);
     shortClass.release();
   });
 
   testRunner("Java char from string", () {
     final characterClass = JCharacter.type.jClass;
-    final m = characterClass
-        .staticMethodId("isLowerCase", "(C)Z")
-        .call(characterClass, const jcharType(), [JValueChar.fromString('X')]);
+    final m = characterClass.staticMethodId("isLowerCase", "(C)Z").call(
+        characterClass, const jbooleanType(), [JValueChar.fromString('X')]);
     expect(m, isFalse);
     characterClass.release();
   });
 
   testRunner("Get static field", () {
     final shortClass = JShort.type.jClass;
-    final maxLong = shortClass
-        .staticFieldId("MAX_VALUE", "S")
-        .get(shortClass, const jshortType());
-    expect(maxLong, equals(32767));
+    final maxLong =
+        shortClass.staticFieldId("MAX_VALUE", "S").get(shortClass, jshort.type);
+    expect(maxLong, 32767);
     shortClass.release();
   });
 
@@ -160,16 +158,16 @@ void run({required TestRunnerCallback testRunner}) {
     final strFromJava = longClass
         .staticMethodId("toOctalString", "(J)Ljava/lang/String;")
         .call(longClass, JString.type, [n]);
-    expect(strFromJava, equals(n.toRadixString(8)));
+    expect(strFromJava.toDartString(releaseOriginal: true), n.toRadixString(8));
     longClass.release();
   });
 
   testRunner("Passing strings in arguments", () {
     final byteClass = JByte.type.jClass;
     final parseByte =
         byteClass.staticMethodId("parseByte", "(Ljava/lang/String;)B");
-    final twelve = parseByte(byteClass, const jbyteType(), ["12"]);
-    expect(twelve, equals(12));
+    final twelve = parseByte(byteClass, const jbyteType(), ["12".toJString()]);
+    expect(twelve, 12);
     byteClass.release();
   });
 
@@ -215,7 +213,7 @@ void run({required TestRunnerCallback testRunner}) {
               .instanceMethodId("ordinal", "()I")
               .call(http, jint.type, []),
         );
-    expect(ordinal, equals(1));
+    expect(ordinal, 1);
     proxyTypeClass.release();
   });
 
@@ -265,7 +263,7 @@ void run({required TestRunnerCallback testRunner}) {
         final integerClass = JInteger.type.jClass;
         return JClass.forName("java/lang/Integer")
             .staticMethodId("parseInt", "(Ljava/lang/String;)I")
-            .call(integerClass, jint.type, ["X"]);
+            .call(integerClass, jint.type, ["X".toJString()]);
       },
       throwsA(isA<JniException>()),
     );
@@ -288,6 +286,6 @@ void run({required TestRunnerCallback testRunner}) {
     final longClass = JLong.type.jClass;
     final maxLong =
         longClass.staticFieldId("MAX_VALUE", "J").get(longClass, jlong.type);
-    expect(maxLong, equals(maxLongInJava));
+    expect(maxLong, maxLongInJava);
   });
 }

pkgs/jnigen/example/in_app_java/lib/main.dart

@@ -9,8 +9,8 @@ import 'package:jni/jni.dart';
 // structure.
 import 'android_utils.dart';
 
-JObject activity = JObject.fromRef(Jni.getCurrentActivity());
-JObject context = JObject.fromRef(Jni.getCachedApplicationContext());
+JObject activity = JObject.fromReference(Jni.getCurrentActivity());
+JObject context = JObject.fromReference(Jni.getCachedApplicationContext());
 
 final hashmap = HashMap.new2(K: JString.type, V: JString.type);
 

pkgs/jnigen/example/notification_plugin/example/lib/main.dart

@@ -10,7 +10,7 @@ import 'package:jni/jni.dart';
 // more customization in future.
 import 'package:notification_plugin/notifications.dart';
 
-JObject activity = JObject.fromRef(Jni.getCurrentActivity());
+JObject activity = JObject.fromReference(Jni.getCurrentActivity());
 
 int i = 0;
 

pkgs/jnigen/example/pdfbox_plugin/dart_example/bin/pdf_info.dart

@@ -10,8 +10,10 @@ import 'package:jni/jni.dart';
 import 'package:pdfbox_plugin/pdfbox_plugin.dart';
 
 void writeInfo(String file) {
-  final inputFile = Jni.newInstance(
-      "java/io/FileInputStream", "(Ljava/lang/String;)V", [file]);
+  final fileInputStreamClass = JClass.forName("java/io/FileInputStream");
+  final inputFile = fileInputStreamClass
+      .constructorId("(Ljava/lang/String;)V")
+      .call(fileInputStreamClass, JObject.type, [file.toJString()]);
   final pdDoc = PDDocument.load6(inputFile);
   int pages = pdDoc.getNumberOfPages();
   final info = pdDoc.getDocumentInformation();

pkgs/jnigen/example/pdfbox_plugin/example/lib/main.dart

@@ -167,8 +167,10 @@ class PDFFileInfo {
   PDFFileInfo.usingPDFBox(this.filename) {
     // Since java.io is not directly available, use package:jni API to
     // create a java.io.File object.
-    final inputFile =
-        Jni.newInstance("java/io/File", "(Ljava/lang/String;)V", [filename]);
+    final fileClass = JClass.forName("java/io/File");
+    final inputFile = fileClass
+        .constructorId("(Ljava/lang/String;)V")
+        .call(fileClass, JObject.type, [filename]);
     // Static method call PDDocument.load -> PDDocument
     final pdf = PDDocument.load(inputFile);
     // Instance method call getNumberOfPages() -> int