Skip to content

Commit 4af11a0

Browse files
[jnigen] CI Fix: update AGP and fix compile sdk version (#1562)
1 parent 20f8160 commit 4af11a0

File tree

24 files changed

+76
-34
lines changed

24 files changed

+76
-34
lines changed

.github/workflows/jnigen.yaml

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ jobs:
8484
- uses: actions/setup-java@6a0805fcefea3d4657a47ac4c165951e33482018
8585
with:
8686
distribution: 'zulu'
87-
java-version: '11'
87+
java-version: '17'
8888
cache: maven
8989
## Committed bindings are formatted with clang-format.
9090
## So this is required to format generated bindings identically
@@ -135,7 +135,7 @@ jobs:
135135
- uses: actions/setup-java@6a0805fcefea3d4657a47ac4c165951e33482018
136136
with:
137137
distribution: 'zulu'
138-
java-version: '11'
138+
java-version: '17'
139139
- uses: axel-op/googlejavaformat-action@fe78db8a90171b6a836449f8d0e982d5d71e5c5a
140140
name: 'Check Java formatting with google-java-format'
141141
with:
@@ -173,7 +173,7 @@ jobs:
173173
- uses: actions/setup-java@6a0805fcefea3d4657a47ac4c165951e33482018
174174
with:
175175
distribution: 'zulu'
176-
java-version: '11'
176+
java-version: '17'
177177
- run: |
178178
sudo apt-get update -y
179179
sudo apt-get install -y ninja-build libgtk-3-dev libclang-dev
@@ -222,7 +222,7 @@ jobs:
222222
- uses: actions/setup-java@6a0805fcefea3d4657a47ac4c165951e33482018
223223
with:
224224
distribution: 'zulu'
225-
java-version: '11'
225+
java-version: '17'
226226
- run: Add-Content $env:GITHUB_PATH "$env:JAVA_HOME\bin\server"
227227
- run: dart pub get
228228
- run: dart run jni:setup
@@ -249,7 +249,7 @@ jobs:
249249
- uses: actions/setup-java@6a0805fcefea3d4657a47ac4c165951e33482018
250250
with:
251251
distribution: 'zulu'
252-
java-version: '11'
252+
java-version: '17'
253253
- run: git config --global core.autocrlf true
254254
- run: Add-Content $env:GITHUB_PATH "$env:JAVA_HOME\bin\server"
255255
- run: dart pub get
@@ -275,7 +275,7 @@ jobs:
275275
- uses: actions/setup-java@6a0805fcefea3d4657a47ac4c165951e33482018
276276
with:
277277
distribution: 'temurin'
278-
java-version: '11'
278+
java-version: '17'
279279
- run: dart pub get
280280
- run: dart run jni:setup
281281
- run: dart test --test-randomize-ordering-seed random
@@ -300,7 +300,7 @@ jobs:
300300
- uses: actions/setup-java@6a0805fcefea3d4657a47ac4c165951e33482018
301301
with:
302302
distribution: 'temurin'
303-
java-version: '11'
303+
java-version: '17'
304304
- run: git config --global core.autocrlf true
305305
- run: dart pub get
306306
- name: Build summarizer
@@ -323,7 +323,7 @@ jobs:
323323
- uses: actions/setup-java@6a0805fcefea3d4657a47ac4c165951e33482018
324324
with:
325325
distribution: 'zulu'
326-
java-version: '11'
326+
java-version: '17'
327327
- run: |
328328
sudo apt-get update -y
329329
sudo apt-get install -y ninja-build libgtk-3-dev
@@ -347,7 +347,7 @@ jobs:
347347
- uses: actions/setup-java@6a0805fcefea3d4657a47ac4c165951e33482018
348348
with:
349349
distribution: 'zulu'
350-
java-version: '11'
350+
java-version: '17'
351351
- run: flutter config --enable-windows-desktop
352352
- run: flutter pub get
353353
- run: flutter build windows
@@ -362,7 +362,7 @@ jobs:
362362
- uses: actions/setup-java@6a0805fcefea3d4657a47ac4c165951e33482018
363363
with:
364364
distribution: 'zulu'
365-
java-version: '11'
365+
java-version: '17'
366366
- uses: subosito/flutter-action@44ac965b96f18d999802d4b807e3256d5a3f9fa1
367367
with:
368368
channel: 'stable'
@@ -386,7 +386,7 @@ jobs:
386386
- uses: actions/setup-java@6a0805fcefea3d4657a47ac4c165951e33482018
387387
with:
388388
distribution: 'zulu'
389-
java-version: '11'
389+
java-version: '17'
390390
- run: |
391391
sudo apt-get update -y
392392
sudo apt-get install -y ninja-build libgtk-3-dev clang-format

pkgs/jni/example/android/app/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,8 @@ if (flutterVersionName == null) {
2323
}
2424

2525
android {
26+
namespace "com.github.dart_lang.jni_example"
27+
2628
compileSdkVersion flutter.compileSdkVersion
2729
ndkVersion flutter.ndkVersion
2830

pkgs/jni/example/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip

pkgs/jni/example/android/settings.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ pluginManagement {
1818

1919
plugins {
2020
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
21-
id "com.android.application" version "7.3.0" apply false
21+
id "com.android.application" version "8.6.0" apply false
2222
id "org.jetbrains.kotlin.android" version "1.7.10" apply false
2323
}
2424

pkgs/jni/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ environment:
2121
dependencies:
2222
args: ^2.3.1
2323
collection: ^1.0.0
24-
ffi: ^2.0.1
24+
ffi: ^2.1.3
2525
package_config: ^2.1.0
2626
path: ^1.8.0
2727
plugin_platform_interface: ^2.0.2

pkgs/jnigen/android_test_runner/android/app/build.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ if (flutterVersionName == null) {
2323
}
2424

2525
android {
26-
compileSdkVersion flutter.compileSdkVersion
26+
namespace "com.github.dart_lang.jnigen.android_integration_test"
27+
28+
compileSdkVersion 35
2729
ndkVersion flutter.ndkVersion
2830

2931
compileOptions {
@@ -42,7 +44,6 @@ android {
4244
}
4345

4446
defaultConfig {
45-
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
4647
applicationId "com.github.dart_lang.jnigen.android_integration_test"
4748
// You can update the following values to match your application needs.
4849
// For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-gradle-build-configuration.

pkgs/jnigen/android_test_runner/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip

pkgs/jnigen/android_test_runner/android/settings.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ pluginManagement {
1818

1919
plugins {
2020
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
21-
id "com.android.application" version "7.3.0" apply false
21+
id "com.android.application" version "8.6.0" apply false
2222
id "org.jetbrains.kotlin.android" version "1.7.10" apply false
2323
}
2424

pkgs/jnigen/example/in_app_java/android/app/build.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ if (flutterVersionName == null) {
2323
}
2424

2525
android {
26-
compileSdkVersion flutter.compileSdkVersion
26+
namespace "com.example.in_app_java"
27+
28+
compileSdkVersion 35
2729
ndkVersion flutter.ndkVersion
2830

2931
compileOptions {
@@ -40,7 +42,6 @@ android {
4042
}
4143

4244
defaultConfig {
43-
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
4445
applicationId "com.example.in_app_java"
4546
// You can update the following values to match your application needs.
4647
// For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-build-configuration.

pkgs/jnigen/example/in_app_java/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip

pkgs/jnigen/example/in_app_java/android/settings.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ pluginManagement {
1818

1919
plugins {
2020
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
21-
id "com.android.application" version "7.3.0" apply false
21+
id "com.android.application" version "8.6.0" apply false
2222
id "org.jetbrains.kotlin.android" version "1.7.10" apply false
2323
}
2424

pkgs/jnigen/example/in_app_java/lib/android_utils.dart

Lines changed: 29 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2855,6 +2855,9 @@ class Build_VERSION_CODES extends jni.JObject {
28552855

28562856
/// from: `static public final int UPSIDE_DOWN_CAKE`
28572857
static const UPSIDE_DOWN_CAKE = 34;
2858+
2859+
/// from: `static public final int VANILLA_ICE_CREAM`
2860+
static const VANILLA_ICE_CREAM = 35;
28582861
static final _id_new$ = _class.constructorId(
28592862
r'()V',
28602863
);
@@ -4130,6 +4133,32 @@ class HashMap<$K extends jni.JObject, $V extends jni.JObject>
41304133
return _clone(reference.pointer, _id_clone as jni.JMethodIDPtr)
41314134
.object(const jni.JObjectType());
41324135
}
4136+
4137+
static final _id_newHashMap = _class.staticMethodId(
4138+
r'newHashMap',
4139+
r'(I)Ljava/util/HashMap;',
4140+
);
4141+
4142+
static final _newHashMap = ProtectedJniExtensions.lookup<
4143+
ffi.NativeFunction<
4144+
jni.JniResult Function(ffi.Pointer<ffi.Void>, jni.JMethodIDPtr,
4145+
ffi.VarArgs<($Int32,)>)>>('globalEnv_CallStaticObjectMethod')
4146+
.asFunction<
4147+
jni.JniResult Function(
4148+
ffi.Pointer<ffi.Void>, jni.JMethodIDPtr, int)>();
4149+
4150+
/// from: `static public java.util.HashMap newHashMap(int i)`
4151+
/// The returned object must be released after use, by calling the [release] method.
4152+
static HashMap<$K, $V>
4153+
newHashMap<$K extends jni.JObject, $V extends jni.JObject>(
4154+
int i, {
4155+
required jni.JObjType<$K> K,
4156+
required jni.JObjType<$V> V,
4157+
}) {
4158+
return _newHashMap(
4159+
_class.reference.pointer, _id_newHashMap as jni.JMethodIDPtr, i)
4160+
.object($HashMapType(K, V));
4161+
}
41334162
}
41344163

41354164
final class $HashMapType<$K extends jni.JObject, $V extends jni.JObject>

pkgs/jnigen/example/kotlin_plugin/android/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ apply plugin: 'com.android.library'
1414
apply plugin: 'kotlin-android'
1515

1616
android {
17+
namespace 'com.example.kotlin_plugin'
18+
1719
// Bumping the plugin compileSdkVersion requires all clients of this plugin
1820
// to bump the version in their app.
1921
compileSdkVersion 31

pkgs/jnigen/example/kotlin_plugin/example/android/app/build.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ if (flutterVersionName == null) {
2323
}
2424

2525
android {
26-
compileSdkVersion flutter.compileSdkVersion
26+
namespace "com.example.kotlin_plugin.example"
27+
28+
compileSdkVersion 35
2729
ndkVersion flutter.ndkVersion
2830

2931
compileOptions {
@@ -40,7 +42,6 @@ android {
4042
}
4143

4244
defaultConfig {
43-
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
4445
applicationId "com.example.kotlin_plugin.example"
4546
// You can update the following values to match your application needs.
4647
// For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-gradle-build-configuration.

pkgs/jnigen/example/kotlin_plugin/example/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip

pkgs/jnigen/example/kotlin_plugin/example/android/settings.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ pluginManagement {
1818

1919
plugins {
2020
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
21-
id "com.android.application" version "7.3.0" apply false
21+
id "com.android.application" version "8.6.0" apply false
2222
id "org.jetbrains.kotlin.android" version "1.7.10" apply false
2323
}
2424

pkgs/jnigen/example/notification_plugin/android/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ rootProject.allprojects {
1313
apply plugin: 'com.android.library'
1414

1515
android {
16+
namespace 'com.example.notification_plugin'
17+
1618
// Bumping the plugin compileSdkVersion requires all clients of this plugin
1719
// to bump the version in their app.
1820
compileSdkVersion 31

pkgs/jnigen/example/notification_plugin/example/android/app/build.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ if (flutterVersionName == null) {
2323
}
2424

2525
android {
26-
compileSdkVersion flutter.compileSdkVersion
26+
namespace "com.example.notification_plugin_example"
27+
28+
compileSdkVersion 35
2729
ndkVersion flutter.ndkVersion
2830

2931
compileOptions {
@@ -40,7 +42,6 @@ android {
4042
}
4143

4244
defaultConfig {
43-
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
4445
applicationId "com.example.notification_plugin_example"
4546
// You can update the following values to match your application needs.
4647
// For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-build-configuration.

pkgs/jnigen/example/notification_plugin/example/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
33
zipStoreBase=GRADLE_USER_HOME
44
zipStorePath=wrapper/dists
5-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-all.zip
5+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip

pkgs/jnigen/example/notification_plugin/example/android/settings.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ pluginManagement {
1818

1919
plugins {
2020
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
21-
id "com.android.application" version "7.3.0" apply false
21+
id "com.android.application" version "8.6.0" apply false
2222
id "org.jetbrains.kotlin.android" version "1.7.10" apply false
2323
}
2424

pkgs/jnigen/example/pdfbox_plugin/android/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,8 @@ rootProject.allprojects {
1313
apply plugin: 'com.android.library'
1414

1515
android {
16+
namespace 'com.example.pdfbox_plugin'
17+
1618
// Bumping the plugin compileSdkVersion requires all clients of this plugin
1719
// to bump the version in their app.
1820
compileSdkVersion 31

pkgs/jnigen/example/pdfbox_plugin/example/android/app/build.gradle

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,9 @@ if (flutterVersionName == null) {
2323
}
2424

2525
android {
26-
compileSdkVersion flutter.compileSdkVersion
26+
namespace "com.example.pdfbox_plugin_example"
27+
28+
compileSdkVersion 35
2729
ndkVersion flutter.ndkVersion
2830

2931
compileOptions {
@@ -40,7 +42,6 @@ android {
4042
}
4143

4244
defaultConfig {
43-
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html).
4445
applicationId "com.example.pdfbox_plugin_example"
4546
// You can update the following values to match your application needs.
4647
// For more information, see: https://docs.flutter.dev/deployment/android#reviewing-the-build-configuration.

pkgs/jnigen/example/pdfbox_plugin/example/android/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,4 +3,4 @@ distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-8.7-all.zip

pkgs/jnigen/example/pdfbox_plugin/example/android/settings.gradle

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ pluginManagement {
1818

1919
plugins {
2020
id "dev.flutter.flutter-plugin-loader" version "1.0.0"
21-
id "com.android.application" version "7.3.0" apply false
21+
id "com.android.application" version "8.6.0" apply false
2222
id "org.jetbrains.kotlin.android" version "1.7.10" apply false
2323
}
2424

0 commit comments

Comments
 (0)