Skip to content

[native_toolchain_c] Tool variants #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dcharkes opened this issue Apr 26, 2023 · 0 comments
Open

[native_toolchain_c] Tool variants #20

dcharkes opened this issue Apr 26, 2023 · 0 comments
Labels
P3 A lower priority bug or feature request package:native_toolchain_c type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-enhancement A request for a change that isn't a bug

Comments

@dcharkes
Copy link
Collaborator

Currently, our Tools are considered equal if they represent the same conceptual tool. E.g. clang is the same conceptual tool whether it's the one for the host OS and the one for Android. ToolInstances are only equal if they point to the actual identical uri and identical version.

Some middle ground could be something like a ToolVariant.
Currently the only variants I have encountered have to do with the Target architecture and operating system:

  • clang: for host and Android.
  • GCC: for cross compiling.
  • MSVC tools: per target architecture (also per host architecture).

We might need to address this to do a better job in the Tool Recognizers when Dart/Flutter passes us just a Uri of an executable and we don't know which tool variant this is.

@dcharkes dcharkes added type-enhancement A request for a change that isn't a bug P3 A lower priority bug or feature request type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable labels Apr 26, 2023
@dcharkes dcharkes changed the title [c_compiler] Tool variants [native_toolchain_c] Tool variants Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 A lower priority bug or feature request package:native_toolchain_c type-code-health Internal changes to our tools and workflows to make them cleaner, simpler, or more maintainable type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

1 participant