Skip to content

[native_assets_cli] BuildOutput API #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Tracked by #882
dcharkes opened this issue Apr 28, 2023 · 2 comments · Fixed by #946
Closed
Tracked by #882

[native_assets_cli] BuildOutput API #25

dcharkes opened this issue Apr 28, 2023 · 2 comments · Fixed by #946
Labels
P2 A bug or feature request we're likely to work on package:hooks

Comments

@dcharkes
Copy link
Collaborator

It seems that this BuildOutput doesn't make a real API (such as output.addAsset(...)) instead it exposes it's constituent fields. Some of those fields like assets are mutable, others are not mutable.

It may be better to provide an API that one can use to add things to the output. The API can be hierarchical just like the config.

What should this API look like?
And should we separate API from implementation?

Related discussions:

@dcharkes dcharkes added the P2 A bug or feature request we're likely to work on label Apr 28, 2023
@dcharkes
Copy link
Collaborator Author

dcharkes commented Aug 1, 2023

One thing to do here is to make a clean API, rather than exposing the fields.

@dcharkes
Copy link
Collaborator Author

@mosuem as promised: This is the API that requires some iteration. 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 A bug or feature request we're likely to work on package:hooks
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant