package:github is reported as Web-only

[filiph]

https://pub.dev/packages/github has both web and io support. See: https://github.com/SpinlockLabs/github.dart/tree/master/lib.

cc @robrbecker, the author

[jonasfj]

Yes, the classification is not ideal, it contains two libraries from what I can see, one for server and one for browser.

And it doesn't contain a github.dart library, so it's hard to know which is the primary.

I think our classification logic is scheduled for a bit of improvement.

[robrbecker]

I've noticed this too and wanted to use conditional import/exports with one entry point to work around it. Looks like someone coincidentally just yesterday put up a PR to do just that SpinlockLabs/github.dart#183

In general, I don't love the split between io and html. Maybe this will make things easier to work everywhere dart-lang/sdk#35969

[jonasfj]

Support for conditional imports in package analysis is still missing #2763.

But I'm sure we'll get that sorted out at some point.

[jonasfj]

Note: for http, just use package:http/http.dart it does conditional imports on its own... So you'll only need to do the env variable thing by importing a different file.

[robrbecker]

@jonasfj I've started refactoring to a single cross platform entry point. Will this layout work better with detection in pub? https://github.com/SpinlockLabs/github.dart/tree/dev

[jonasfj]

@robrbecker, not yet, but I strongly suspect we'll eventually need to support conditional imports in the platform detection logic -- which is going to be refactored soon, anyways.

[robrbecker]

I've released version 6 which seems to detect correctly, even with conditional imports.

Looks like you can close this issue.

[jonasfj]

Ah, it doesn't detect anything when you use an empty stub as the default case... Or so I think..

We still don't have proper support for conditional imports in pana. But we are look at this soon.