Fix more tests

Author: nehalvpatel

lib/src/authentication/client.dart

@@ -48,19 +48,14 @@ class _AuthenticatedClient extends http.BaseClient {
           await _credential!.getAuthorizationHeaderValue();
     }
 
-    try {
-      final response = await _inner.send(request);
-      if (response.statusCode == 401) {
-        _detectInvalidCredentials = true;
-        _throwAuthException(response);
-      }
-      return response;
-    } on PubHttpResponseException catch (e) {
-      if (e.response.statusCode == 403) {
-        _throwAuthException(e.response);
-      }
-      rethrow;
+    final response = await _inner.send(request);
+    if (response.statusCode == 401) {
+      _detectInvalidCredentials = true;
+    }
+    if (response.statusCode == 401 || response.statusCode == 403) {
+      _throwAuthException(response);
     }
+    return response;
   }
 
   /// Throws [AuthenticationException] that includes response status code and

lib/src/http.dart

@@ -293,16 +293,28 @@ Future<T> retryForHttp<T>(String operation, FutureOr<T> Function() fn) async {
 }
 
 extension Throwing on http.BaseResponse {
+  /// See https://api.flutter.dev/flutter/dart-io/HttpClientRequest/followRedirects.html
+  static const _redirectStatusCodes = [
+    HttpStatus.movedPermanently,
+    HttpStatus.movedTemporarily,
+    HttpStatus.seeOther,
+    HttpStatus.temporaryRedirect,
+    HttpStatus.permanentRedirect
+  ];
+
   /// Throws [PubHttpResponseException], calls [fail], or does nothing depending
   /// on the status code.
   ///
-  /// If the code is in the 200 range, nothing is done. If the code is 408, 429,
-  /// or in the 500 range, [PubHttpResponseException] is thrown with
-  /// "isIntermittent" set to `true`. Otherwise, [PubHttpResponseException] is
-  /// thrown with "isIntermittent" set to `false`.
+  /// If the code is in the 200 range or if its a 300 range redirect code,
+  /// nothing is done. If the code is 408, 429, or in the 500 range,
+  /// [PubHttpResponseException] is thrown with "isIntermittent" set to `true`.
+  /// Otherwise, [PubHttpResponseException] is thrown with "isIntermittent" set
+  /// to `false`.
   void throwIfNotOk() {
     if (statusCode >= 200 && statusCode <= 299) {
       return;
+    } else if (_redirectStatusCodes.contains(statusCode)) {
+      return;
     } else if (statusCode == HttpStatus.notAcceptable &&
         request?.headers['Accept'] == pubApiHeaders['Accept']) {
       fail('Pub ${sdk.version} is incompatible with the current version of '

test/hosted/fail_gracefully_on_url_resolve_test.dart

@@ -20,7 +20,8 @@ void main() {
       ]).create();
 
       await pubCommand(command,
-          error: 'Could not resolve URL "https://invalid-url.foo".',
+          error: 'Got socket error trying to find package foo at '
+              'https://invalid-url.foo.',
           exitCode: exit_codes.UNAVAILABLE,
           environment: {
             'PUB_MAX_HTTP_RETRIES': '2',