-
Notifications
You must be signed in to change notification settings - Fork 231
Allow excluding entrypoints from the dart2js transformer #691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent
If you got the fastest builds some other (for purposes of discussion magical) way, would you still care to control which files are compiled? Can you frame this bug in terms of the problem you're running into? Added this to the Later milestone. |
<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd Sure, performance aside. (although, that's a big part of this. compiling to JS is non trivial) Let's say I have App A, but experiment E. E might be busted, only works in Dartium, won't be deployed, just for me. I don't want to slow down the build, introduce extraneous error messages or warnings, or break the build if all I care about is App A. So I guess this is about cycle times mostly, and reducing warnings/output about broken builds that I know are broken. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Issue #739 has been merged into this issue. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Removed Priority-Unassigned label. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Removed Priority-Medium label. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent Marked this as blocking dart-lang/sdk#15829. |
<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3 I believe the current plan for issue #695 will cover this use case. As such, can we close out this bug? |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent We now let you specify which directory you want to build, but not which entrypoints. This ticket is a bit vague. If you specify some entrypoint, presumably you do also want all of the other assets needed by that entrypoint. Is it more that you want to exclude certain entrypoints from being compiled using dart2js? |
<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd Sure, excluding entry points would help. See https://code.google.com/p/dart/issues/detail?id=14594#c2 In that case, I wanted to say "don't build this thing, it's busted and I know it" |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent OK, retargeting the bug. Changed the title to: "Allow excluding entrypoints from the dart2js transformer". |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent I'm gonna start poking at this. My plan is to add support for $exclude and $include to transformers in general, and then we'll get dart2js for free. cc @nex3. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent $include and $exclude are in. Added Fixed label. |
<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd thanks! We might want to document this. CC'ing Sharon. cc @Sfshaza. |
<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent |
<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="96" height="96"hspace="10"> Issue by sethladd
Originally opened as dart-lang/sdk#14594
Currently, pub build finds all .dart files in web/ with a main(). I want the fastest builds, so I'd like to say which files I want compiled.
I'd like a way to specify the entry points that I want pub build to process
.
The text was updated successfully, but these errors were encountered: