Skip to content

Allow excluding entrypoints from the dart2js transformer #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
DartBot opened this issue Jun 5, 2015 · 14 comments
Closed

Allow excluding entrypoints from the dart2js transformer #691

DartBot opened this issue Jun 5, 2015 · 14 comments
Assignees
Labels
type-enhancement A request for a change that isn't a bug

Comments

@DartBot
Copy link

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="96" height="96"hspace="10"> Issue by sethladd
Originally opened as dart-lang/sdk#14594


Currently, pub build finds all .dart files in web/ with a main(). I want the fastest builds, so I'd like to say which files I want compiled.

I'd like a way to specify the entry points that I want pub build to process
.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


I want the fastest builds, so I'd like to say which files I want compiled.

If you got the fastest builds some other (for purposes of discussion magical) way, would you still care to control which files are compiled? Can you frame this bug in terms of the problem you're running into?


Added this to the Later milestone.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


Sure, performance aside. (although, that's a big part of this. compiling to JS is non trivial)

Let's say I have App A, but experiment E. E might be busted, only works in Dartium, won't be deployed, just for me. I don't want to slow down the build, introduce extraneous error messages or warnings, or break the build if all I care about is App A.

So I guess this is about cycle times mostly, and reducing warnings/output about broken builds that I know are broken.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Issue #739 has been merged into this issue.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Removed Priority-Unassigned label.
Added Priority-Medium label.

@DartBot DartBot added type-enhancement A request for a change that isn't a bug Fixed labels Jun 5, 2015
@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Removed Priority-Medium label.
Added Priority-High label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Marked this as blocking dart-lang/sdk#15829.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/188?v=3" align="left" width="48" height="48"hspace="10"> Comment by nex3


I believe the current plan for issue #695 will cover this use case. As such, can we close out this bug?

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


We now let you specify which directory you want to build, but not which entrypoints.

This ticket is a bit vague. If you specify some entrypoint, presumably you do also want all of the other assets needed by that entrypoint. Is it more that you want to exclude certain entrypoints from being compiled using dart2js?

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


Sure, excluding entry points would help. See https://code.google.com/p/dart/issues/detail?id=14594#c2 In that case, I wanted to say "don't build this thing, it's busted and I know it"

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


OK, retargeting the bug.


Changed the title to: "Allow excluding entrypoints from the dart2js transformer".

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


I'm gonna start poking at this. My plan is to add support for $exclude and $include to transformers in general, and then we'll get dart2js for free.


cc @nex3.
Set owner to @munificent.
Added Started label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


$include and $exclude are in.


Added Fixed label.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/5479?v=3" align="left" width="48" height="48"hspace="10"> Comment by sethladd


thanks!

We might want to document this. CC'ing Sharon.


cc @Sfshaza.

@DartBot
Copy link
Author

DartBot commented Jun 5, 2015

<img src="https://avatars.githubusercontent.com/u/46275?v=3" align="left" width="48" height="48"hspace="10"> Comment by munificent


Yup: https://code.google.com/p/dart/issues/detail?id=17128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type-enhancement A request for a change that isn't a bug
Projects
None yet
Development

No branches or pull requests

2 participants