Skip to content

Commit 022d92e

Browse files
whesseCommit Queue
authored and
Commit Queue
committed
[infra] Fix utility used when bisecting CI failures
The bisection capability for failing builds on the CI is not much used, and it is failing when updating the build information in Firestore. A simple error in the script is causing the current error, so this CL fixes a simple error in tools/bots/update_blamelists.dart. Bug: #51978 Change-Id: Iba71e6115427145d20458d9e56f4cfa73fa232c9 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/302923 Auto-Submit: William Hesse <[email protected]> Commit-Queue: Jonas Termansen <[email protected]> Reviewed-by: Jonas Termansen <[email protected]>
1 parent 0767670 commit 022d92e

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tools/bots/update_blamelists.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ bool shouldUpdateRecord(ResultRecord resultRecord, Result? testResult) {
9595
return true;
9696
}
9797

98-
void updateBlameLists(String configuration, String commit,
98+
Future<void> updateBlameLists(String configuration, String commit,
9999
Map<String, Map<String, dynamic>> testResults) async {
100100
int commitIndex = await getCommitIndex(commit);
101101
var query = unapprovedActiveFailuresQuery(configuration);
@@ -179,6 +179,6 @@ main(List<String> arguments) async {
179179
var project = options['staging'] ? 'dart-ci-staging' : 'dart-ci';
180180
database = FirestoreDatabase(
181181
project, await readGcloudAuthToken(options['auth-token']));
182-
updateBlameLists(configuration, commit, results);
182+
await updateBlameLists(configuration, commit, results);
183183
database.closeClient();
184184
}

0 commit comments

Comments
 (0)