Skip to content

Commit 1450896

Browse files
mkustermannCommit Queue
authored and
Commit Queue
committed
[vm] Ensure platform/globals.h is included before using defines
Defines may be defined/modified/cleared in `platform/globals.h`. All VM sources should directly or indirectly include `platform/globals.h` before using defines. TEST=ci Change-Id: Icf67eddd94a18775d4247259049906c9cc6014cd Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/275020 Reviewed-by: Daco Harkes <[email protected]> Commit-Queue: Martin Kustermann <[email protected]>
1 parent 2a0bcaf commit 1450896

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

runtime/vm/compiler/backend/flow_graph_checker.cc

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,8 @@
22
// for details. All rights reserved. Use of this source code is governed by a
33
// BSD-style license that can be found in the LICENSE file.
44

5+
#include "platform/globals.h"
6+
57
#if defined(DEBUG)
68

79
#include "vm/compiler/backend/flow_graph_checker.h"

runtime/vm/compiler/backend/flow_graph_checker.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,8 @@
55
#ifndef RUNTIME_VM_COMPILER_BACKEND_FLOW_GRAPH_CHECKER_H_
66
#define RUNTIME_VM_COMPILER_BACKEND_FLOW_GRAPH_CHECKER_H_
77

8+
#include "platform/globals.h"
9+
810
#if defined(DART_PRECOMPILED_RUNTIME)
911
#error "AOT runtime should not use compiler sources (including header files)"
1012
#endif // defined(DART_PRECOMPILED_RUNTIME)

0 commit comments

Comments
 (0)