Skip to content

Commit 14be3fb

Browse files
pqCommit Queue
authored and
Commit Queue
committed
don't report one_member_abstracts on macro classes
Completes: https://github.com/dart-lang/linter/issues/4924 Change-Id: I27095ed1dd07c8c9662776d83c5dbfc8fd478e64 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/365900 Commit-Queue: Phil Quitslund <[email protected]> Reviewed-by: Konstantin Shcheglov <[email protected]>
1 parent b64c9ee commit 14be3fb

File tree

2 files changed

+11
-0
lines changed

2 files changed

+11
-0
lines changed

pkg/linter/lib/src/rules/one_member_abstracts.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ class _Visitor extends SimpleAstVisitor<void> {
7070
if (node.abstractKeyword == null) return;
7171
if (node.extendsClause != null) return;
7272

73+
if (node.macroKeyword != null) return;
7374
if (node.isAugmentation) return;
7475

7576
var element = node.declaredElement;

pkg/linter/test/rules/one_member_abstracts_test.dart

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,16 @@ class OneMemberAbstractsTest extends LintRuleTest {
1717
@override
1818
String get lintRule => 'one_member_abstracts';
1919

20+
test_macroClass() async {
21+
await assertDiagnostics(r'''
22+
abstract macro class M {
23+
void m();
24+
}
25+
''', [
26+
// TODO(pq): add abstract macro compilation error when implemented
27+
]);
28+
}
29+
2030
test_oneMember_abstract() async {
2131
await assertDiagnostics(r'''
2232
abstract class C {

0 commit comments

Comments
 (0)