augmentation support for use_key_in_widget_constructors

Fixes: https://github.com/dart-lang/linter/issues/4936

Change-Id: Ib002878a1f7bf59db684f957d36eaf4e1a5b97bf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/362843
Commit-Queue: Phil Quitslund <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Author: pq

pkg/linter/lib/src/extensions.dart

@@ -126,6 +126,9 @@ extension BlockExtension on Block {
 }
 
 extension ClassElementExtension on ClassElement {
+  /// Get all constructors, including merged augmentations.
+  List<ConstructorElement> get allConstructors => augmented.constructors;
+
   /// Get all fields, including merged augmentations.
   List<FieldElement> get allFields => augmented.fields;
 

pkg/linter/lib/src/rules/use_key_in_widget_constructors.dart

@@ -68,14 +68,16 @@ class _Visitor extends SimpleAstVisitor<void> {
     if (classElement != null &&
         classElement.isPublic &&
         hasWidgetAsAscendant(classElement) &&
-        classElement.constructors.where((e) => !e.isSynthetic).isEmpty) {
+        classElement.allConstructors.where((e) => !e.isSynthetic).isEmpty) {
       rule.reportLintForToken(node.name);
     }
     super.visitClassDeclaration(node);
   }
 
   @override
   void visitConstructorDeclaration(ConstructorDeclaration node) {
+    if (node.isAugmentation) return;
+
     var constructorElement = node.declaredElement;
     if (constructorElement == null) {
       return;

pkg/linter/lib/src/util/flutter_utils.dart

@@ -85,14 +85,16 @@ class _Flutter {
 
   bool hasWidgetAsAscendant(InterfaceElement? element,
       [Set<InterfaceElement>? alreadySeen]) {
+    if (element == null) return false;
+
+    if (isExactly(element, _nameWidget, _uriFramework)) return true;
+
     alreadySeen ??= {};
-    if (element == null || !alreadySeen.add(element)) {
-      return false;
-    }
-    if (isExactly(element, _nameWidget, _uriFramework)) {
-      return true;
-    }
-    return hasWidgetAsAscendant(element.supertype?.element, alreadySeen);
+    if (!alreadySeen.add(element)) return false;
+
+    var type =
+        element.isAugmentation ? element.augmented.thisType : element.supertype;
+    return hasWidgetAsAscendant(type?.element, alreadySeen);
   }
 
   bool isBuildContext(DartType? type, {bool skipNullable = false}) {

pkg/linter/test/rules/use_key_in_widget_constructors_test.dart

@@ -20,6 +20,30 @@ class UseKeyInWidgetConstructorsTest extends LintRuleTest {
   @override
   String get lintRule => 'use_key_in_widget_constructors';
 
+  test_augmentedConstructor_noKey() async {
+    newFile('$testPackageLibPath/a.dart', r'''
+import augment 'test.dart';
+import 'package:flutter/widgets.dart';
+
+class W extends StatelessWidget {
+  W();
+
+  @override
+  Widget build(BuildContext context) => Container();
+}
+''');
+
+    await assertNoDiagnostics(r'''
+augment library 'a.dart';
+
+import 'package:flutter/widgets.dart';
+
+augment class W {
+  augment const W();
+}
+''');
+  }
+
   test_constNamedConstructor_missingKey() async {
     await assertDiagnostics(r'''
 import 'package:flutter/widgets.dart';
@@ -32,6 +56,57 @@ abstract class MyWidget extends StatelessWidget {
     ]);
   }
 
+  test_constructorInAugmentedClass() async {
+    newFile('$testPackageLibPath/a.dart', r'''
+import augment 'test.dart';
+import 'package:flutter/widgets.dart';
+
+class W extends StatelessWidget {
+  @override
+  Widget build(BuildContext context) => Container();
+}
+''');
+
+    await assertDiagnostics(r'''
+augment library 'a.dart';
+
+import 'package:flutter/foundation.dart';
+import 'package:flutter/widgets.dart';
+
+augment class W { }
+
+augment class W {
+  const W({Key? key});
+}
+''', [
+      lint(156, 1),
+    ]);
+  }
+
+  test_constructorInAugmentedClass_noKeyParam() async {
+    newFile('$testPackageLibPath/a.dart', r'''
+import augment 'test.dart';
+import 'package:flutter/widgets.dart';
+
+class W extends StatelessWidget {
+  @override
+  Widget build(BuildContext context) => Container();
+}
+''');
+
+    await assertDiagnostics(r'''
+augment library 'a.dart';
+
+import 'package:flutter/widgets.dart';
+
+augment class W {
+  const W();
+}
+''', [
+      lint(93, 1),
+    ]);
+  }
+
   test_constUnnamedConstructor_missingKey() async {
     await assertDiagnostics(r'''
 import 'package:flutter/widgets.dart';
@@ -57,6 +132,29 @@ class MyWidget extends StatelessWidget {
 ''');
   }
 
+  test_keyUse_inAugmentedConstructor() async {
+    newFile('$testPackageLibPath/a.dart', r'''
+augment library 'test.dart';
+
+import 'package:flutter/foundation.dart';
+import 'package:flutter/widgets.dart';
+
+augment class W {
+  const W({Key? key}) : super(key: key);
+}
+''');
+
+    await assertNoDiagnostics(r'''
+import augment 'a.dart';
+import 'package:flutter/widgets.dart';
+
+class W extends StatelessWidget {
+  @override
+  Widget build(BuildContext context) => Container();
+}
+''');
+  }
+
   test_missingConstructor() async {
     await assertDiagnostics(r'''
 import 'package:flutter/widgets.dart';