Skip to content

Commit 1a3ae1e

Browse files
askeksaCommit Bot
authored and
Commit Bot
committed
[dart2wasm] Emit nominal types and don't use RTTs by default.
This enables us to upgrade our testing to use a newer version of d8. Change-Id: I79a8879a325b9996b9923304439a3ee8fa5fa02a Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-debug-x64-try Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238345 Reviewed-by: Joshua Litt <[email protected]> Commit-Queue: Aske Simon Christensen <[email protected]>
1 parent cdb7038 commit 1a3ae1e

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

pkg/dart2wasm/dart2wasm.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ where *options* include:
1616
| `--`[`no-`]`lazy-constants` | no | Instantiate constants lazily.
1717
| `--`[`no-`]`local-nullability` | no | Use non-nullable types for non-nullable locals and temporaries.
1818
| `--`[`no-`]`name-section` | yes | Emit Name Section with function names.
19-
| `--`[`no-`]`nominal-types` | no | Emit experimental nominal types.
19+
| `--`[`no-`]`nominal-types` | yes | Emit nominal types.
2020
| `--`[`no-`]`parameter-nullability` | yes | Use non-nullable types for non-nullable parameters and return values.
2121
| `--`[`no-`]`polymorphic-specialization` | no | Do virtual calls by switching on the class ID instead of using `call_indirect`.
2222
| `--`[`no-`]`print-kernel` | no | Print IR for each function before compiling it.
2323
| `--`[`no-`]`print-wasm` | no | Print Wasm instructions of each compiled function.
24-
| `--`[`no-`]`runtime-types` | yes | Use RTTs for allocations and casts.
24+
| `--`[`no-`]`runtime-types` | no | Use RTTs for allocations and casts.
2525
| `--`[`no-`]`string-data-segments` | no | Use experimental array init from data segment for string constants.
2626
| `--watch` *offset* | | Print stack trace leading to the byte at offset *offset* in the `.wasm` output file. Can be specified multiple times.
2727

pkg/dart2wasm/lib/translator.dart

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,12 @@ class TranslatorOptions {
3232
bool lazyConstants = false;
3333
bool localNullability = false;
3434
bool nameSection = true;
35-
bool nominalTypes = false;
35+
bool nominalTypes = true;
3636
bool parameterNullability = true;
3737
bool polymorphicSpecialization = false;
3838
bool printKernel = false;
3939
bool printWasm = false;
40-
bool runtimeTypes = true;
40+
bool runtimeTypes = false;
4141
bool stringDataSegments = false;
4242
List<int>? watchPoints = null;
4343

0 commit comments

Comments
 (0)