Skip to content

Commit 1a6d6f7

Browse files
jensjohaCommit Queue
authored and
Commit Queue
committed
[parser] Add comments to calls
Change-Id: I66756be2c2d979dfbdd50c304f8b083abf2fc034 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280462 Commit-Queue: Jens Johansen <[email protected]> Reviewed-by: Johnni Winther <[email protected]>
1 parent c9f3aca commit 1a6d6f7

File tree

3 files changed

+14
-12
lines changed

3 files changed

+14
-12
lines changed

pkg/_fe_analyzer_shared/lib/src/parser/literal_entry_info_impl.dart

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,8 @@ class ForCondition extends LiteralEntryInfo {
5050
// Process `for ( pattern in expression )`
5151
assert(optional('in', token.next!));
5252
_inStyle = true;
53-
return parser.parseForInLoopPartsRest(
54-
token, awaitToken, forToken, patternKeyword, null);
53+
return parser.parseForInLoopPartsRest(token, awaitToken, forToken,
54+
patternKeyword, /* identifier = */ null);
5555
}
5656
}
5757
Token identifier = token.next!;
@@ -61,7 +61,7 @@ class ForCondition extends LiteralEntryInfo {
6161
// Process `for ( ... in ... )`
6262
_inStyle = true;
6363
token = parser.parseForInLoopPartsRest(
64-
token, awaitToken, forToken, null, identifier);
64+
token, awaitToken, forToken, /* patternKeyword = */ null, identifier);
6565
} else {
6666
// Process `for ( ... ; ... ; ... )`
6767
_inStyle = false;

pkg/_fe_analyzer_shared/lib/src/parser/parser_impl.dart

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -650,7 +650,7 @@ class Parser {
650650
sealedToken,
651651
baseToken,
652652
interfaceToken,
653-
null,
653+
/* mixinToken = */ null,
654654
directiveState);
655655
} else if (identical(value, 'enum')) {
656656
directiveState?.checkDeclaration();
@@ -719,7 +719,7 @@ class Parser {
719719
inlineToken,
720720
sealedToken,
721721
baseToken,
722-
null,
722+
/* interfaceToken = */ null,
723723
keyword,
724724
directiveState);
725725
}
@@ -7844,15 +7844,16 @@ class Parser {
78447844
} else {
78457845
// Process `for ( pattern in expression )`
78467846
assert(optional('in', token.next!));
7847-
return parseForInRest(
7848-
token, awaitToken, forToken, patternKeyword, null);
7847+
return parseForInRest(token, awaitToken, forToken, patternKeyword,
7848+
/* identifier = */ null);
78497849
}
78507850
}
78517851
Token identifier = token.next!;
78527852
token = parseForLoopPartsMid(token, awaitToken, forToken);
78537853
if (optional('in', token.next!) || optional(':', token.next!)) {
78547854
// Process `for ( ... in ... )`
7855-
return parseForInRest(token, awaitToken, forToken, null, identifier);
7855+
return parseForInRest(
7856+
token, awaitToken, forToken, /* patternKeyword = */ null, identifier);
78567857
} else {
78577858
// Process `for ( ... ; ... ; ... )`
78587859
return parseForRest(awaitToken, token, forToken);

pkg/_fe_analyzer_shared/lib/src/scanner/string_canonicalizer.dart

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ class _StringNode extends _Node {
9595

9696
@override
9797
int get hash =>
98-
_StringCanonicalizer.hashString(payload, /*start=*/ 0, payload.length);
98+
_StringCanonicalizer.hashString(payload, /* start = */ 0, payload.length);
9999

100100
// On a 64-bit Dart VM the size of
101101
// * [_StringNode] itself is 32 bytes
@@ -234,7 +234,8 @@ class _StringCanonicalizer {
234234

235235
String canonicalizeString(String data) {
236236
if (_count > _size) rehash();
237-
final int index = hashString(data, /*start=*/ 0, data.length) & (_size - 1);
237+
final int index =
238+
hashString(data, /* start = */ 0, data.length) & (_size - 1);
238239
final _Node? s = _nodes[index];
239240
_Node? t = s;
240241
while (t != null) {
@@ -274,7 +275,7 @@ class _StringCanonicalizer {
274275

275276
void initializeWithSize(int size) {
276277
_size = size;
277-
_nodes = new List<_Node?>.filled(_size, null);
278+
_nodes = new List<_Node?>.filled(_size, /* fill = */ null);
278279
_count = 0;
279280
_utf8StringCount = 0;
280281
_stringCount = 0;
@@ -301,7 +302,7 @@ class _StringCanonicalizer {
301302
// leaving some space before we'll have to prune again next time.
302303

303304
final List<_StringNode> stringNodes = new List<_StringNode>.filled(
304-
_stringCount, new _StringNode('dummy', null));
305+
_stringCount, new _StringNode('dummy', /* next = */ null));
305306
int writeIndex = 0;
306307
for (int i = 0; i < _nodes.length; ++i) {
307308
_Node? node = _nodes[i];

0 commit comments

Comments
 (0)