Skip to content

Commit 1cba9f3

Browse files
sigmundchCommit Queue
sigmundch
authored and
Commit Queue
committed
[tests] Skip multiple html and co19/html tests.
All tests skipped here are flaking or timing out. Most of them fail for a common reason tracked in #53985: Chrome inactive tabs do not run behave the same as active tabs. This means that interactions like css transitions, requestAnimationFrame, and video play don't work as expected. This CL skips the tests only on Chrome, but continues to run them in other browsers where the expectation is met. If we can in the future ensure tests are run on an active tab, we can consider reneabling these tests. That said, the value of this tests was higher when we mantained Dartium, but these days we may consider deleting them instead. Change-Id: I9c0ea230fecca16fa008b64c2cf316ccdd0f53e4 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/335030 Reviewed-by: Srujan Gaddam <[email protected]> Commit-Queue: Sigmund Cherem <[email protected]>
1 parent 40a5f6f commit 1cba9f3

8 files changed

+27
-1
lines changed

‎tests/co19/co19-dart2js.status

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -92,6 +92,9 @@ LibTest/typed_data/ByteData/setUint64_A02_t02: SkipByDesign # 64-bit int not sup
9292
LibTest/typed_data/Int64List/*: SkipByDesign # Int64List not supported on the web
9393
LibTest/typed_data/Uint64List/*: SkipByDesign # Uint64List not supported on the web
9494

95+
[ $compiler == dart2js && $runtime == chrome ]
96+
LibTest/html/Window/animationFrame_A01_t01: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
97+
9598
[ $compiler == dart2js && $runtime == d8 ]
9699
LibTest/html/*: SkipByDesign # d8 is not a browser
97100

@@ -117,5 +120,6 @@ LibTest/core/List/List_class_A01_t05: SkipSlow # slow babeljs transformation
117120
LibTest/core/List/List_class_A01_t06: SkipSlow # slow babeljs transformation
118121

119122
[ $compiler == dart2js && $runtime == safari ]
123+
LibTest/html/Element/isContentEditable_A01_t01: Skip # 98% fails in Safari, evades flake detection https://github.com/dart-lang/sdk/issues/50718
120124
LibTest/html/Element/isContentEditable_A02_t01: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718
121125
LibTest/html/IFrameElement/isContentEditable_A01_t01: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718

‎tests/co19/co19-dartdevc.status

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,3 +89,6 @@ LibTest/typed_data/ByteData/setUint64_A02_t01: SkipByDesign # 64-bit int not sup
8989
LibTest/typed_data/ByteData/setUint64_A02_t02: SkipByDesign # 64-bit int not supported on the web
9090
LibTest/typed_data/Int64List/*: SkipByDesign # Int64List not supported on the web
9191
LibTest/typed_data/Uint64List/*: SkipByDesign # Uint64List not supported on the web
92+
93+
[ $compiler == ddc && $runtime == chrome ]
94+
LibTest/html/Window/animationFrame_A01_t01: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs

‎tests/co19_2/co19_2-dart2js.status

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,11 @@ LibTest/typed_data/ByteData/setUint64_A02_t02: SkipByDesign # 64-bit int not sup
5656
LibTest/typed_data/Int64List/*: SkipByDesign # Int64List not supported on the web
5757
LibTest/typed_data/Uint64List/*: SkipByDesign # Uint64List not supported on the web
5858

59+
[ $compiler == dart2js && $runtime == chrome ]
60+
LibTest/html/Window/animationFrame_A01_t01: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
61+
co19_2/LibTest/html/IFrameElement/blur_A01_t01: SkipByDesign # 62% flaky, unexplained, passes consistently in co19 suite (just flakes in co19_2)
62+
co19_2/LibTest/html/IFrameElement/focus_A01_t01: SkipByDesign # 80% flaky, unexplained, passes consistently in co19 suite (just flakes in co19_2)
63+
5964
[ $compiler == dart2js && $runtime == d8 ]
6065
LibTest/html/*: SkipByDesign # d8 is not a browser
6166

‎tests/co19_2/co19_2-dartdevc.status

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,3 +124,6 @@ LibTest/typed_data/ByteData/setUint64_A02_t01: SkipByDesign # 64-bit int not sup
124124
LibTest/typed_data/ByteData/setUint64_A02_t02: SkipByDesign # 64-bit int not supported on the web
125125
LibTest/typed_data/Int64List/*: SkipByDesign # Int64List not supported on the web
126126
LibTest/typed_data/Uint64List/*: SkipByDesign # Uint64List not supported on the web
127+
128+
[ $compiler == ddc && $runtime == chrome ]
129+
LibTest/html/Window/animationFrame_A01_t01: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs

‎tests/lib/lib_dart2js.status

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,9 @@ async/slow_consumer2_test: SkipSlow # Times out. Issue 22050
3535
convert/streamed_conversion_json_utf8_decode_test: SkipSlow # Times out. Issue 22050
3636
convert/streamed_conversion_json_utf8_encode_test: SkipSlow # Times out. Issue 22050
3737
convert/streamed_conversion_utf8_decode_test: SkipSlow # Times out. Issue 22050
38+
html/canvasrendering/draw_image_video_element_test: SkipByDesign # Issue #53985: video is not played on Chrome inactive tabs
39+
html/request_animation_frame_test: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
40+
html/transition_event_test: SkipByDesign # Issue #53985: css transitions are not executed on Chrome inactive tabs
3841

3942
[ $compiler == dart2js && $runtime == chromeOnAndroid ]
4043
html/input_element_datetime_test: Slow, Pass # TODO(dart2js-team): Please triage this failure.

‎tests/lib/lib_dartdevc.status

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,10 @@ typed_data/int64_list_load_store_test: SkipByDesign # ddc does not support Int64
2929
typed_data/typed_data_hierarchy_int64_test: SkipByDesign # ddc does not support Int64List
3030

3131
[ $compiler == ddc && $runtime == chrome ]
32+
html/canvasrendering/draw_image_video_element_test: SkipByDesign # Issue #53985: video is not played on Chrome inactive tabs
3233
html/js_dispatch_property_test: Skip # Timeout Issue 31030
34+
html/request_animation_frame_test: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
35+
html/transition_event_test: SkipByDesign # Issue #53985: css transitions are not executed on Chrome inactive tabs
3336

3437
[ $compiler == ddc && $runtime == ff ]
3538
html/mediadevices_test: SkipByDesign # Not supported on FF, likely requires user-interaction that causes timeout

‎tests/lib_2/lib_2_dart2js.status

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,9 @@ async/slow_consumer2_test: SkipSlow # Times out. Issue 22050
3333
convert/streamed_conversion_json_utf8_decode_test: SkipSlow # Times out. Issue 22050
3434
convert/streamed_conversion_json_utf8_encode_test: SkipSlow # Times out. Issue 22050
3535
convert/streamed_conversion_utf8_decode_test: SkipSlow # Times out. Issue 22050
36+
html/canvasrendering/draw_image_video_element_test: SkipByDesign # Issue #53985: video is not played on Chrome inactive tabs
37+
html/request_animation_frame_test: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
38+
html/transition_event_test: SkipByDesign # Issue #53985: css transitions are not executed on Chrome inactive tabs
3639

3740
[ $compiler == dart2js && $runtime == chromeOnAndroid ]
3841
html/input_element_datetime_test: Slow, Pass # TODO(dart2js-team): Please triage this failure.
@@ -70,7 +73,6 @@ html/interactive_media_test: SkipSlow
7073
html/mediasource_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718
7174
js/js_util/bigint_test: Skip # evades flake detection https://github.com/dart-lang/sdk/issues/50718
7275

73-
7476
[ $compiler == dart2js && $checked ]
7577
convert/utf85_test: Slow, Pass # Issue 12029.
7678
html/js_function_getter_trust_types/function_test: Skip # --trust-type-annotations incompatible with --checked

‎tests/lib_2/lib_2_dartdevc.status

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,10 @@ js/js_util/js_prefix_test: SkipByDesign # JS$ prefix not implemented on ddc.
2727
mirrors/*: SkipByDesign # Mirrors not supported on web in Dart 2.0.
2828

2929
[ $compiler == ddc && $runtime == chrome ]
30+
html/canvasrendering/draw_image_video_element_test: SkipByDesign # Issue #53985: video is not played on Chrome inactive tabs
3031
html/js_dispatch_property_test: Skip # Timeout Issue 31030
32+
html/request_animation_frame_test: SkipByDesign # Issue #53985: requestAnimationFrame is not executed on Chrome inactive tabs
33+
html/transition_event_test: SkipByDesign # Issue #53985: css transitions are not executed on Chrome inactive tabs
3134

3235
[ $compiler == ddc && $runtime == ff ]
3336
html/mediadevices_test: SkipByDesign # Not supported on FF, likely requires user-interaction that causes timeout

0 commit comments

Comments
 (0)