[infra] Remove obsolete buildbot paths/terms

#42247

Change-Id: Ia0b19677c655bc768f00be77df8b0162ac9e7bea
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150629
Auto-Submit: Alexander Thomas <[email protected]>
Commit-Queue: William Hesse <[email protected]>
Reviewed-by: William Hesse <[email protected]>

Author: athomas

tools/FAKE_COMMITS

@@ -12,13 +12,13 @@ Testing update steps
 Testing bots after GOLO <> gcs failures
 Trigger bots after github outage
 Trigger bots on github pull
-Trigger bots 
+Trigger bots
 Purple is the new green.
 googlecode back up
-CIT outage - all slaves rebooted
+CIT outage - all bots rebooted
 Authentication failure flake - rerun all bots
-Trigger bots after master restart - switch dart2js bots to use downloaded sdk.
-Trigger bots after master restart.
+Trigger bots after restart - switch dart2js bots to use downloaded sdk.
+Trigger bots after restart.
 Trigger mirroring of github repository
 Trigger mirroring of github repository
 Trigger mirroring of github repository

tools/archive_crash.py

@@ -195,39 +195,26 @@ def run(command, env=None, shell=False, throw_on_error=True):
 
 
 class GSUtil(object):
-    GSUTIL_IS_SHELL_SCRIPT = False
     GSUTIL_PATH = None
     USE_DART_REPO_VERSION = False
 
     def _layzCalculateGSUtilPath(self):
         if not GSUtil.GSUTIL_PATH:
-            buildbot_gsutil = '/b/build/scripts/slave/gsutil'
-            if platform.system() == 'Windows':
-                buildbot_gsutil = 'e:\\\\b\\build\\scripts\\slave\\gsutil'
-            if os.path.isfile(
-                    buildbot_gsutil) and not GSUtil.USE_DART_REPO_VERSION:
-                GSUtil.GSUTIL_IS_SHELL_SCRIPT = True
-                GSUtil.GSUTIL_PATH = buildbot_gsutil
+            dart_gsutil = os.path.join(DART_DIR, 'third_party', 'gsutil',
+                                       'gsutil')
+            if os.path.isfile(dart_gsutil):
+                GSUtil.GSUTIL_PATH = dart_gsutil
+            elif GSUtil.USE_DART_REPO_VERSION:
+                raise Exception("Dart repository version of gsutil required, "
+                                "but not found.")
             else:
-                dart_gsutil = os.path.join(DART_DIR, 'third_party', 'gsutil',
-                                           'gsutil')
-                if os.path.isfile(dart_gsutil):
-                    GSUtil.GSUTIL_IS_SHELL_SCRIPT = False
-                    GSUtil.GSUTIL_PATH = dart_gsutil
-                elif GSUtil.USE_DART_REPO_VERSION:
-                    raise Exception(
-                        "Dart repository version of gsutil required, "
-                        "but not found.")
-                else:
-                    # We did not find gsutil, look in path
-                    possible_locations = list(os.environ['PATH'].split(
-                        os.pathsep))
-                    for directory in possible_locations:
-                        location = os.path.join(directory, 'gsutil')
-                        if os.path.isfile(location):
-                            GSUtil.GSUTIL_IS_SHELL_SCRIPT = False
-                            GSUtil.GSUTIL_PATH = location
-                            break
+                # We did not find gsutil, look in path
+                possible_locations = list(os.environ['PATH'].split(os.pathsep))
+                for directory in possible_locations:
+                    location = os.path.join(directory, 'gsutil')
+                    if os.path.isfile(location):
+                        GSUtil.GSUTIL_PATH = location
+                        break
             assert GSUtil.GSUTIL_PATH
 
     def execute(self, gsutil_args):
@@ -238,9 +225,7 @@ def execute(self, gsutil_args):
         else:
             gsutil_command = [sys.executable, GSUtil.GSUTIL_PATH]
 
-        return run(
-            gsutil_command + gsutil_args,
-            shell=(GSUtil.GSUTIL_IS_SHELL_SCRIPT and sys.platform == 'win32'))
+        return run(gsutil_command + gsutil_args)
 
     def upload(self,
                local_path,

tools/bots/bot_utils.py

@@ -101,21 +101,5 @@ def _WriteFile(path, lines):
                 # Sleep for 50 ms and try again
                 time.sleep(0.05)
             else:
-                # FIXME(kustermann): Remove this later on.
-                # We try to get more debugging information to figure out why we
-                # sometimes get a "Permission denied" error when opening the file for
-                # writing. (hypothesis: Another process has already opened the file.)
                 _logger.info('Got exception (%s) ' % error)
-
-                if sys.platform == 'win32':
-                    handle_file = r'E:\handle.exe'
-                    if os.path.exists(handle_file):
-                        _logger.info(
-                            'Running handle.exe for debugging purposes')
-                        subprocess.call(
-                            [handle_file, '-a', r'E:\b\build\slave'])
-                    else:
-                        _logger.info(
-                            "Couldn't find %s. Not printing open handles." %
-                            handle_file)
                 raise error

tools/dom/scripts/multiemitter.py

@@ -292,13 +292,6 @@ def ListDartArgCallback(option, value, parser):
 VERSION_FILE = os.path.join(DART_DIR, 'tools', 'VERSION')
 
 
-def GetBuildbotGSUtilPath():
-    gsutil = '/b/build/scripts/slave/gsutil'
-    if platform.system() == 'Windows':
-        gsutil = 'e:\\\\b\\build\\scripts\\slave\\gsutil'
-    return gsutil
-
-
 def GetBuildMode(mode):
     return BUILD_MODES[mode]