Squelch some false warnings for disallowed uses of void

The rules for void are changed to allow uses of void where we
previously had a warning, such as the case of assignment to a
variable of type void or passing as a parameter of type void.

Change-Id: I1c1513b0000fa1c8eedbe2645fab503b28024fa3
Reviewed-on: https://dart-review.googlesource.com/70265
Reviewed-by: Daniel Hillerström <[email protected]>
Reviewed-by: Aske Simon Christensen <[email protected]>
Commit-Queue: Kevin Millikin <[email protected]>

Author: Kevin Millikin

pkg/analyzer/test/generated/static_warning_code_kernel_test.dart

@@ -576,20 +576,4 @@ class StaticWarningCodeTest_Kernel extends StaticWarningCodeTest_Driver {
   test_undefinedIdentifier_function() async {
     return super.test_undefinedIdentifier_function();
   }
-
-  @override
-  @failingTest
-  test_useOfVoidResult_await() async {
-    return super.test_useOfVoidResult_await();
-  }
-
-  @override
-  test_useOfVoidResult_inForLoop_ok() async {
-    return super.test_useOfVoidResult_inForLoop_ok();
-  }
-
-  @override
-  test_useOfVoidResult_variableDeclaration_method_ok() async {
-    return super.test_useOfVoidResult_variableDeclaration_method_ok();
-  }
 }

pkg/analyzer/test/generated/static_warning_code_test.dart

@@ -1743,11 +1743,7 @@ void main() {
 void f(void x) {}
 ''');
     await computeAnalysisResult(source);
-    if (useCFE) {
-      assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
-    } else {
-      assertNoErrors(source);
-    }
+    assertNoErrors(source);
   }
 
   test_generalizedVoid_assignToVoid_notStrong_error() async {
@@ -2088,11 +2084,7 @@ void main() {
 }
 ''');
     await computeAnalysisResult(source);
-    if (useCFE) {
-      assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
-    } else {
-      assertNoErrors(source);
-    }
+    assertNoErrors(source);
   }
 
   test_generalizedVoid_useOfVoidInMapLiteralKeyError() async {
@@ -2114,11 +2106,7 @@ void main() {
 }
 ''');
     await computeAnalysisResult(source);
-    if (useCFE) {
-      assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
-    } else {
-      assertNoErrors(source);
-    }
+    assertNoErrors(source);
   }
 
   test_generalizedVoid_useOfVoidInMapLiteralValueError() async {
@@ -2140,11 +2128,7 @@ void main() {
 }
 ''');
     await computeAnalysisResult(source);
-    if (useCFE) {
-      assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
-    } else {
-      assertNoErrors(source);
-    }
+    assertNoErrors(source);
   }
 
   test_generalizedVoid_useOfVoidInNullOperatorLhsError() async {
@@ -2166,11 +2150,7 @@ void main() {
 }
 ''');
     await computeAnalysisResult(source);
-    if (useCFE) {
-      assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
-    } else {
-      assertNoErrors(source);
-    }
+    assertNoErrors(source);
   }
 
   test_generalizedVoid_useOfVoidInSpecialAssignmentError() async {
@@ -2182,7 +2162,10 @@ void main() {
 ''');
     await computeAnalysisResult(source);
     if (useCFE) {
-      assertErrors(source, [StaticTypeWarningCode.UNDEFINED_METHOD]);
+      assertErrors(source, [
+        StaticTypeWarningCode.UNDEFINED_METHOD,
+        StaticWarningCode.USE_OF_VOID_RESULT
+      ]);
     } else {
       assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
     }
@@ -2290,11 +2273,7 @@ void main() {
 }
 ''');
     await computeAnalysisResult(source);
-    if (useCFE) {
-      assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
-    } else {
-      assertNoErrors(source);
-    }
+    assertNoErrors(source);
   }
 
   test_importDuplicatedLibraryNamed() async {
@@ -4885,10 +4864,7 @@ class A {
 }''');
     await computeAnalysisResult(source);
     if (useCFE) {
-      assertErrors(source, [
-        StaticWarningCode.USE_OF_VOID_RESULT,
-        StaticWarningCode.USE_OF_VOID_RESULT
-      ]);
+      assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
     } else {
       assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
     }
@@ -4906,10 +4882,7 @@ class A {
 }''');
     await computeAnalysisResult(source);
     if (useCFE) {
-      assertErrors(source, [
-        StaticWarningCode.USE_OF_VOID_RESULT,
-        StaticWarningCode.USE_OF_VOID_RESULT
-      ]);
+      assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
     } else {
       assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
     }
@@ -4949,11 +4922,7 @@ class A {
   }
 }''');
     await computeAnalysisResult(source);
-    if (useCFE) {
-      assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
-    } else {
-      assertNoErrors(source);
-    }
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -4979,11 +4948,7 @@ class A {
   }
 }''');
     await computeAnalysisResult(source);
-    if (useCFE) {
-      assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
-    } else {
-      assertNoErrors(source);
-    }
+    assertNoErrors(source);
     verify([source]);
   }
 
@@ -5025,11 +4990,7 @@ class A {
   }
 }''');
     await computeAnalysisResult(source);
-    if (useCFE) {
-      assertErrors(source, [StaticWarningCode.USE_OF_VOID_RESULT]);
-    } else {
-      assertNoErrors(source);
-    }
+    assertNoErrors(source);
     verify([source]);
   }