Ignore return statements for @doNotStore in tests

Bug: #45594
Change-Id: I83574cc456d6259c0627d902c4bbfb2310055caf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196243
Reviewed-by: Phil Quitslund <[email protected]>
Commit-Queue: Phil Quitslund <[email protected]>

Author: jiahaog

pkg/analyzer/lib/src/error/best_practices_verifier.dart

@@ -653,7 +653,9 @@ class BestPracticesVerifier extends RecursiveAstVisitor<void> {
 
   @override
   void visitReturnStatement(ReturnStatement node) {
-    _checkForReturnOfDoNotStore(node.expression);
+    if (!_invalidAccessVerifier._inTestDirectory) {
+      _checkForReturnOfDoNotStore(node.expression);
+    }
     super.visitReturnStatement(node);
   }
 

pkg/analyzer/test/src/diagnostics/return_of_do_not_store_test.dart

@@ -37,6 +37,10 @@ String f() {
   var v = () => _v;
   return v();
 }
+
+String g() {
+  return _v;
+}
 ''',
     );
   }