[cfe] isWildcard set only with experiment on.

Only set `isWildcard` on variables when the experiment for wildcards is enabled.

Bug: #55655
Change-Id: I54a1f0ba1b9192df6c86e44e92d5ff4bebc9a232
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/371020
Commit-Queue: Kallen Tu <[email protected]>
Reviewed-by: Chloe Stefantsova <[email protected]>

Author: kallentu

pkg/front_end/lib/src/fasta/kernel/body_builder.dart

@@ -3885,7 +3885,8 @@ class BodyBuilder extends StackListenerImpl
         isRequired: isRequired,
         hasDeclaredInitializer: initializer != null,
         isStaticLate: isFinal && initializer == null,
-        isWildcard: identifier.name == '_')
+        isWildcard: identifier.name == '_' &&
+            libraryFeatures.wildcardVariables.isEnabled)
       ..fileOffset = identifier.nameOffset
       ..fileEqualsOffset = offsetForToken(equalsToken);
     typeInferrer.assignedVariables.declare(variable);

pkg/front_end/testcases/general/arithmetic.dart.strong.expect

@@ -7,7 +7,7 @@ static method foo(core::int x, core::int y) → core::int {
   return z.{core::int::<<}(4){(core::int) → core::int};
 }
 static method loop(core::List<dynamic> xs) → void {
-  wildcard core::int _ = xs.{core::List::length}{core::int};
+  core::int _ = xs.{core::List::length}{core::int};
   for (core::int i = 0; i.{core::num::<}(xs.{core::List::length}{core::int}){(core::num) → core::bool}; i = i.{core::num::+}(1){(core::num) → core::int}) {
   }
 }

pkg/front_end/testcases/general/arithmetic.dart.strong.modular.expect

@@ -7,7 +7,7 @@ static method foo(core::int x, core::int y) → core::int {
   return z.{core::int::<<}(4){(core::int) → core::int};
 }
 static method loop(core::List<dynamic> xs) → void {
-  wildcard core::int _ = xs.{core::List::length}{core::int};
+  core::int _ = xs.{core::List::length}{core::int};
   for (core::int i = 0; i.{core::num::<}(xs.{core::List::length}{core::int}){(core::num) → core::bool}; i = i.{core::num::+}(1){(core::num) → core::int}) {
   }
 }

pkg/front_end/testcases/general/arithmetic.dart.strong.transformed.expect

@@ -7,7 +7,7 @@ static method foo(core::int x, core::int y) → core::int {
   return z.{core::int::<<}(4){(core::int) → core::int};
 }
 static method loop(core::List<dynamic> xs) → void {
-  wildcard core::int _ = xs.{core::List::length}{core::int};
+  core::int _ = xs.{core::List::length}{core::int};
   for (core::int i = 0; i.{core::num::<}(xs.{core::List::length}{core::int}){(core::num) → core::bool}; i = i.{core::num::+}(1){(core::num) → core::int}) {
   }
 }

pkg/front_end/testcases/general/closure.dart.strong.expect

@@ -14,7 +14,7 @@ class Bar extends core::Object {
     ;
 }
 static method useCallback(dynamic callback) → dynamic {
-  wildcard dynamic _ = callback{dynamic}();
+  dynamic _ = callback{dynamic}();
 }
 static method main() → dynamic {
   dynamic x;
@@ -23,5 +23,5 @@ static method main() → dynamic {
     return new self::Foo::•();
   }
   self::useCallback(inner);
-  wildcard self::Bar _ = inner(){() → self::Foo}.{self::Foo::_field}{self::Bar};
+  self::Bar _ = inner(){() → self::Foo}.{self::Foo::_field}{self::Bar};
 }

pkg/front_end/testcases/general/closure.dart.strong.modular.expect

@@ -14,7 +14,7 @@ class Bar extends core::Object {
     ;
 }
 static method useCallback(dynamic callback) → dynamic {
-  wildcard dynamic _ = callback{dynamic}();
+  dynamic _ = callback{dynamic}();
 }
 static method main() → dynamic {
   dynamic x;
@@ -23,5 +23,5 @@ static method main() → dynamic {
     return new self::Foo::•();
   }
   self::useCallback(inner);
-  wildcard self::Bar _ = inner(){() → self::Foo}.{self::Foo::_field}{self::Bar};
+  self::Bar _ = inner(){() → self::Foo}.{self::Foo::_field}{self::Bar};
 }

pkg/front_end/testcases/general/closure.dart.strong.transformed.expect

@@ -14,7 +14,7 @@ class Bar extends core::Object {
     ;
 }
 static method useCallback(dynamic callback) → dynamic {
-  wildcard dynamic _ = callback{dynamic}();
+  dynamic _ = callback{dynamic}();
 }
 static method main() → dynamic {
   dynamic x;
@@ -23,5 +23,5 @@ static method main() → dynamic {
     return new self::Foo::•();
   }
   self::useCallback(inner);
-  wildcard self::Bar _ = inner(){() → self::Foo}.{self::Foo::_field}{self::Bar};
+  self::Bar _ = inner(){() → self::Foo}.{self::Foo::_field}{self::Bar};
 }

pkg/front_end/testcases/general/escape.dart.strong.expect

@@ -28,10 +28,10 @@ class X extends core::Object implements self::A, self::B {
     ;
 }
 static method useAsA(self::A object) → void {
-  wildcard dynamic _ = object.{self::A::field}{dynamic};
+  dynamic _ = object.{self::A::field}{dynamic};
 }
 static method useAsB(self::B object) → void {
-  wildcard dynamic _ = object.{self::B::field}{dynamic};
+  dynamic _ = object.{self::B::field}{dynamic};
   self::escape(object);
 }
 static method escape(dynamic x) → void {

pkg/front_end/testcases/general/escape.dart.strong.modular.expect

@@ -28,10 +28,10 @@ class X extends core::Object implements self::A, self::B {
     ;
 }
 static method useAsA(self::A object) → void {
-  wildcard dynamic _ = object.{self::A::field}{dynamic};
+  dynamic _ = object.{self::A::field}{dynamic};
 }
 static method useAsB(self::B object) → void {
-  wildcard dynamic _ = object.{self::B::field}{dynamic};
+  dynamic _ = object.{self::B::field}{dynamic};
   self::escape(object);
 }
 static method escape(dynamic x) → void {

pkg/front_end/testcases/general/escape.dart.strong.transformed.expect

@@ -28,10 +28,10 @@ class X extends core::Object implements self::A, self::B {
     ;
 }
 static method useAsA(self::A object) → void {
-  wildcard dynamic _ = object.{self::A::field}{dynamic};
+  dynamic _ = object.{self::A::field}{dynamic};
 }
 static method useAsB(self::B object) → void {
-  wildcard dynamic _ = object.{self::B::field}{dynamic};
+  dynamic _ = object.{self::B::field}{dynamic};
   self::escape(object);
 }
 static method escape(dynamic x) → void {

pkg/front_end/testcases/general/issue48347.dart.strong.expect

@@ -5,7 +5,7 @@ import "dart:async" as asy;
 import "dart:async";
 
 static method test(asy::StreamController<void> _eventStreamController) → dynamic async /* emittedValueType= dynamic */ {
-  await for (final wildcard void _ in _eventStreamController.{asy::StreamController::stream}{asy::Stream<void>}) {
+  await for (final void _ in _eventStreamController.{asy::StreamController::stream}{asy::Stream<void>}) {
   }
 }
 static method main() → dynamic {}

pkg/front_end/testcases/general/issue48347.dart.strong.modular.expect

@@ -5,7 +5,7 @@ import "dart:async" as asy;
 import "dart:async";
 
 static method test(asy::StreamController<void> _eventStreamController) → dynamic async /* emittedValueType= dynamic */ {
-  await for (final wildcard void _ in _eventStreamController.{asy::StreamController::stream}{asy::Stream<void>}) {
+  await for (final void _ in _eventStreamController.{asy::StreamController::stream}{asy::Stream<void>}) {
   }
 }
 static method main() → dynamic {}

pkg/front_end/testcases/general/issue48347.dart.strong.transformed.expect

@@ -11,7 +11,7 @@ static method test(asy::StreamController<void> _eventStreamController) → dynam
     synthesized asy::_StreamIterator<void>? :for-iterator = new asy::_StreamIterator::•<void>(:stream);
     try
       while (let dynamic #t1 = asy::_asyncStarMoveNextHelper(:stream) in await :for-iterator.{asy::_StreamIterator::moveNext}(){() → asy::Future<core::bool>}) {
-        final wildcard void _ = :for-iterator.{asy::_StreamIterator::current}{void};
+        final void _ = :for-iterator.{asy::_StreamIterator::current}{void};
         {}
       }
     finally

pkg/front_end/testcases/patterns/issue52345.dart.strong.expect

@@ -6,7 +6,7 @@ static method main() → void {
   final core::List<core::String> works = <core::String>["b", "l"];
   final core::List<core::String> fails = <core::String>["c"];
   for (final core::List<core::String> test in <core::List<core::String>>[works, fails]) {
-    final wildcard void _ = block {
+    final void _ = block {
       void #t1;
       final synthesized core::List<core::String> #0#0 = test;
       synthesized core::int #0#1;

pkg/front_end/testcases/patterns/issue52345.dart.strong.modular.expect

@@ -6,7 +6,7 @@ static method main() → void {
   final core::List<core::String> works = <core::String>["b", "l"];
   final core::List<core::String> fails = <core::String>["c"];
   for (final core::List<core::String> test in <core::List<core::String>>[works, fails]) {
-    final wildcard void _ = block {
+    final void _ = block {
       void #t1;
       final synthesized core::List<core::String> #0#0 = test;
       synthesized core::int #0#1;

pkg/front_end/testcases/patterns/issue52345.dart.strong.transformed.expect

@@ -10,7 +10,7 @@ static method main() → void {
     for (; :sync-for-iterator.{core::Iterator::moveNext}(){() → core::bool}; ) {
       final core::List<core::String> test = :sync-for-iterator.{core::Iterator::current}{core::List<core::String>};
       {
-        final wildcard void _ = block {
+        final void _ = block {
           void #t1;
           final synthesized core::List<core::String> #0#0 = test;
           synthesized core::int #0#1;

pkg/front_end/testcases/records/block_combine_statements.dart.strong.expect

@@ -4,7 +4,7 @@ import "dart:core" as core;
 import "dart:_internal" as _in;
 
 static method main() → void {
-  for (wildcard(core::Iterable<core::int>, core::Iterable<core::int>) _ in self::split<core::int>(<core::int>[1, 2, 3])) {
+  for ((core::Iterable<core::int>, core::Iterable<core::int>) _ in self::split<core::int>(<core::int>[1, 2, 3])) {
   }
 }
 static method split<A extends core::Object? = dynamic>(core::Iterable<self::split::A%> it) → core::Iterable<(core::Iterable<self::split::A%>, core::Iterable<self::split::A%>)>

pkg/front_end/testcases/records/block_combine_statements.dart.strong.modular.expect

@@ -4,7 +4,7 @@ import "dart:core" as core;
 import "dart:_internal" as _in;
 
 static method main() → void {
-  for (wildcard(core::Iterable<core::int>, core::Iterable<core::int>) _ in self::split<core::int>(<core::int>[1, 2, 3])) {
+  for ((core::Iterable<core::int>, core::Iterable<core::int>) _ in self::split<core::int>(<core::int>[1, 2, 3])) {
   }
 }
 static method split<A extends core::Object? = dynamic>(core::Iterable<self::split::A%> it) → core::Iterable<(core::Iterable<self::split::A%>, core::Iterable<self::split::A%>)>

pkg/front_end/testcases/records/block_combine_statements.dart.strong.transformed.expect

@@ -7,7 +7,7 @@ static method main() → void {
   {
     synthesized core::Iterator<(core::Iterable<core::int>, core::Iterable<core::int>)> :sync-for-iterator = self::split<core::int>(core::_GrowableList::_literal3<core::int>(1, 2, 3)).{core::Iterable::iterator}{core::Iterator<(core::Iterable<core::int>, core::Iterable<core::int>)>};
     for (; :sync-for-iterator.{core::Iterator::moveNext}(){() → core::bool}; ) {
-      wildcard(core::Iterable<core::int>, core::Iterable<core::int>) _ = :sync-for-iterator.{core::Iterator::current}{(core::Iterable<core::int>, core::Iterable<core::int>)};
+      (core::Iterable<core::int>, core::Iterable<core::int>) _ = :sync-for-iterator.{core::Iterator::current}{(core::Iterable<core::int>, core::Iterable<core::int>)};
       {}
     }
   }