verify linter source sorting

Fixes: https://github.com/dart-lang/linter/issues/2368

Change-Id: I498e271dc32348115a34472b44688be8de2169a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/323901
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>

Author: pq

pkg/analysis_server/test/verify_sorted_test.dart

@@ -28,6 +28,10 @@ void main() {
     buildTestsForAnalyzerPlugin();
   });
 
+  group('linter', () {
+    buildTestsForLinter();
+  });
+
   group('nnbd_migration', () {
     buildTestsForNnbdMigration();
   });
@@ -50,13 +54,10 @@ void buildTests({
     excludedPaths: excludedPaths,
     resourceProvider: provider,
   );
-  var contexts = collection.contexts;
-  if (contexts.length != 1) {
-    fail('The directory $packagePath contains multiple analysis contexts.');
+  for (var context in collection.contexts) {
+    buildTestsIn(context.currentSession, packagePath, excludedPaths,
+        provider.getFolder(packagePath));
   }
-
-  buildTestsIn(contexts[0].currentSession, packagePath, excludedPaths,
-      provider.getFolder(packagePath));
 }
 
 void buildTestsForAnalysisServer() {
@@ -120,6 +121,12 @@ void buildTestsForAnalyzerPlugin() {
   );
 }
 
+void buildTestsForLinter() {
+  buildTests(packagePath: 'linter', excludedPaths: [
+    'test_data',
+  ]);
+}
+
 void buildTestsForNnbdMigration() {
   buildTests(
       packagePath: 'nnbd_migration',

pkg/linter/lib/src/rules/avoid_empty_else.dart

@@ -28,16 +28,16 @@ class AvoidEmptyElse extends LintRule {
       correctionMessage:
           'Try removing the empty statement or removing the else clause.');
 
-  @override
-  LintCode get lintCode => code;
-
   AvoidEmptyElse()
       : super(
             name: 'avoid_empty_else',
             description: _desc,
             details: _details,
             group: Group.errors);
 
+  @override
+  LintCode get lintCode => code;
+
   @override
   void registerNodeProcessors(
       NodeLintRegistry registry, LinterContext context) {

pkg/linter/lib/src/rules/avoid_positional_boolean_parameters.dart

@@ -93,6 +93,11 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
   }
 
+  @override
+  void visitGenericFunctionType(GenericFunctionType node) {
+    checkParams(node.parameters.parameters);
+  }
+
   @override
   void visitMethodDeclaration(MethodDeclaration node) {
     var declaredElement = node.declaredElement;
@@ -106,11 +111,6 @@ class _Visitor extends SimpleAstVisitor<void> {
     }
   }
 
-  @override
-  void visitGenericFunctionType(GenericFunctionType node) {
-    checkParams(node.parameters.parameters);
-  }
-
   bool _isOverridingMember(Element member) {
     var classElement = member.thisOrAncestorOfType<ClassElement>();
     if (classElement == null) return false;

pkg/linter/lib/src/rules/avoid_relative_lib_imports.dart

@@ -47,16 +47,16 @@ class AvoidRelativeLibImports extends LintRule {
           "Try fixing the relative path or changing the import to a 'package:' "
           'import.');
 
-  @override
-  LintCode get lintCode => code;
-
   AvoidRelativeLibImports()
       : super(
             name: 'avoid_relative_lib_imports',
             description: _desc,
             details: _details,
             group: Group.errors);
 
+  @override
+  LintCode get lintCode => code;
+
   @override
   void registerNodeProcessors(
       NodeLintRegistry registry, LinterContext context) {

pkg/linter/lib/src/rules/avoid_return_types_on_setters.dart

@@ -27,9 +27,6 @@ set speed(int ms);
 ''';
 
 class AvoidReturnTypesOnSetters extends LintRule {
-  @override
-  bool get canUseParsedResult => true;
-
   static const LintCode code = LintCode(
       'avoid_return_types_on_setters', 'Unnecessary return type on a setter.',
       correctionMessage: 'Try removing the return type.');
@@ -41,6 +38,9 @@ class AvoidReturnTypesOnSetters extends LintRule {
             details: _details,
             group: Group.style);
 
+  @override
+  bool get canUseParsedResult => true;
+
   @override
   LintCode get lintCode => code;
 

pkg/linter/lib/src/rules/collection_methods_unrelated_type.dart

@@ -88,6 +88,16 @@ class CollectionMethodsUnrelatedType extends LintRule {
 class _Visitor extends UnrelatedTypesProcessors {
   _Visitor(super.rule, super.typeSystem, super.typeProvider);
 
+  @override
+  List<MethodDefinition> get indexOperators => [
+        // Argument to `Map<K, V>.[]` should be assignable to `K`.
+        MethodDefinitionForElement(
+          typeProvider.mapElement,
+          '[]',
+          ExpectedArgumentKind.assignableToCollectionTypeArgument,
+        ),
+      ];
+
   @override
   List<MethodDefinition> get methods => [
         // Argument to `Iterable<E>.contains` should be assignable to `E`.
@@ -141,14 +151,4 @@ class _Visitor extends UnrelatedTypesProcessors {
           ExpectedArgumentKind.assignableToCollectionTypeArgument,
         ),
       ];
-
-  @override
-  List<MethodDefinition> get indexOperators => [
-        // Argument to `Map<K, V>.[]` should be assignable to `K`.
-        MethodDefinitionForElement(
-          typeProvider.mapElement,
-          '[]',
-          ExpectedArgumentKind.assignableToCollectionTypeArgument,
-        ),
-      ];
 }

pkg/linter/lib/src/rules/curly_braces_in_flow_control_structures.dart

@@ -51,9 +51,6 @@ if (overflowChars != other.overflowChars) {
 ''';
 
 class CurlyBracesInFlowControlStructures extends LintRule {
-  @override
-  bool get canUseParsedResult => true;
-
   static const LintCode code = LintCode(
       'curly_braces_in_flow_control_structures',
       'Statements in {0} should be enclosed in a block.',
@@ -66,6 +63,9 @@ class CurlyBracesInFlowControlStructures extends LintRule {
             details: _details,
             group: Group.style);
 
+  @override
+  bool get canUseParsedResult => true;
+
   @override
   LintCode get lintCode => code;
 

pkg/linter/lib/src/rules/library_annotations.dart

@@ -68,10 +68,10 @@ class LibraryAnnotations extends LintRule {
 class _Visitor extends SimpleAstVisitor<void> {
   final LibraryAnnotations rule;
 
-  _Visitor(this.rule);
-
   Directive? firstDirective;
 
+  _Visitor(this.rule);
+
   @override
   void visitCompilationUnit(CompilationUnit node) {
     if (node.directives.isNotEmpty) {

pkg/linter/lib/src/rules/no_literal_bool_comparisons.dart

@@ -61,6 +61,11 @@ class _Visitor extends SimpleAstVisitor<void> {
 
   _Visitor(this.rule, this.context);
 
+  bool isBool(DartType? type) =>
+      type != null &&
+      type.isDartCoreBool &&
+      context.typeSystem.isNonNullable(type);
+
   @override
   void visitBinaryExpression(BinaryExpression node) {
     if (node.operator.type == TokenType.EQ_EQ ||
@@ -74,9 +79,4 @@ class _Visitor extends SimpleAstVisitor<void> {
       }
     }
   }
-
-  bool isBool(DartType? type) =>
-      type != null &&
-      type.isDartCoreBool &&
-      context.typeSystem.isNonNullable(type);
 }

pkg/linter/lib/src/rules/no_self_assignments.dart

@@ -5,6 +5,7 @@
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
 import 'package:analyzer/dart/ast/visitor.dart';
+
 import '../analyzer.dart';
 
 const _desc = r"Don't assign a variable to itself.";