Remove dart:mirrors library from dart2js and ddc SDKs

nshahan · commit-bot@chromium.org · commit 35cd61819a51 · 2020-02-07T17:34:54.000Z
A followup change will delete the patches that are no longer needed once these changes have been "mirrored" :P to the libraries files in the flutter repos. Change-Id: I7d255838b97922198248b29311facd4956001e25 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134405 Commit-Queue: Nicholas Shahan <nshahan@google.com> Reviewed-by: Sigmund Cherem <sigmund@google.com>
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -42,6 +42,10 @@ additional details see the [announcement].
   `allowInterop`. This behavior was always enforced by `dart2js`, but was not
   enforced consistently in `ddc`. It will now be enforced in both.
 * JS interop classes with an index operator are now static errors.
+* Removed the `dart:mirrors` library from the SDK. Use of this library on the
+  web has been unsupported and prevented by the Dart build systems since Dart
+  v2.0.0. All known exception cases have been cleaned up. This change makes DDC
+  and dart2js now issue a compile-time error directly as well.
 
  [announcement]: https://github.com/dart-lang/sdk/issues/38994
 
@@ -53,6 +57,10 @@ additional details see the [announcement].
   forgiving. Corresponding type parameter bounds now only need to be mutual
   subtypes rather than structurally equal up to renaming of bound type variables
   and equating all top types.
+* Removed the `dart:mirrors` library from the SDK. Use of this library on the
+  web has been unsupported and prevented by the Dart build systems since Dart
+  v2.0.0. All known exception cases have been cleaned up. This change makes DDC
+  and dart2js now issue a compile-time error directly as well.
 
 #### Linter
 
diff --git a/pkg/compiler/lib/src/kernel/dart2js_target.dart b/pkg/compiler/lib/src/kernel/dart2js_target.dart
@@ -183,7 +183,6 @@ const _requiredLibraries = const <String, List<String>>{
     'dart:io',
     'dart:js',
     'dart:js_util',
-    'dart:mirrors',
     'dart:svg',
     'dart:web_audio',
     'dart:web_gl',
@@ -202,7 +201,6 @@ const _requiredLibraries = const <String, List<String>>{
     'dart:io',
     'dart:js',
     'dart:js_util',
-    'dart:mirrors',
   ]
 };
 
diff --git a/pkg/dev_compiler/lib/src/kernel/target.dart b/pkg/dev_compiler/lib/src/kernel/target.dart
@@ -45,7 +45,6 @@ class DevCompilerTarget extends Target {
         'dart:_internal',
         'dart:_isolate_helper',
         'dart:_js_helper',
-        'dart:_js_mirrors',
         'dart:_js_primitives',
         'dart:_metadata',
         'dart:_native_typed_data',
@@ -58,7 +57,6 @@ class DevCompilerTarget extends Target {
         'dart:js',
         'dart:js_util',
         'dart:math',
-        'dart:mirrors',
         'dart:typed_data',
         'dart:indexed_db',
         'dart:html',
diff --git a/sdk/lib/libraries.json b/sdk/lib/libraries.json
@@ -217,11 +217,6 @@
         "uri": "math/math.dart",
         "patches": "_internal/js_runtime/lib/math_patch.dart"
       },
-      "mirrors": {
-        "uri": "mirrors/mirrors.dart",
-        "patches": "_internal/js_runtime/lib/mirrors_patch_cfe.dart",
-        "supported": false
-      },
       "typed_data": {
         "uri": "typed_data/typed_data.dart",
         "patches": "_internal/js_runtime/lib/typed_data_patch.dart"
@@ -327,11 +322,6 @@
         "uri": "math/math.dart",
         "patches": "_internal/js_runtime/lib/math_patch.dart"
       },
-      "mirrors": {
-        "uri": "mirrors/mirrors.dart",
-        "patches": "_internal/js_runtime/lib/mirrors_patch_cfe.dart",
-        "supported": false
-      },
       "typed_data": {
         "uri": "typed_data/typed_data.dart",
         "patches": "_internal/js_runtime/lib/typed_data_patch.dart"
@@ -399,9 +389,6 @@
       "_js_helper": {
         "uri": "_internal/js_dev_runtime/private/js_helper.dart"
       },
-      "_js_mirrors": {
-        "uri": "_internal/js_dev_runtime/private/js_mirrors.dart"
-      },
       "_js_primitives": {
         "uri": "_internal/js_dev_runtime/private/js_primitives.dart"
       },
@@ -441,11 +428,6 @@
         "patches": "_internal/js_dev_runtime/patch/isolate_patch.dart",
         "supported": false
       },
-      "mirrors": {
-        "uri": "mirrors/mirrors.dart",
-        "patches": "_internal/js_dev_runtime/patch/mirrors_patch.dart",
-        "supported": false
-      },
       "math": {
         "uri": "math/math.dart",
         "patches": "_internal/js_dev_runtime/patch/math_patch.dart"
diff --git a/sdk/lib/libraries.yaml b/sdk/lib/libraries.yaml
@@ -214,11 +214,6 @@ dart2js:
       uri: "math/math.dart"
       patches: "_internal/js_runtime/lib/math_patch.dart"
 
-    mirrors:
-      uri: "mirrors/mirrors.dart"
-      patches: "_internal/js_runtime/lib/mirrors_patch_cfe.dart"
-      supported: false
-
     typed_data:
       uri: "typed_data/typed_data.dart"
       patches: "_internal/js_runtime/lib/typed_data_patch.dart"
@@ -322,11 +317,6 @@ dart2js_server:
       uri: "math/math.dart"
       patches: "_internal/js_runtime/lib/math_patch.dart"
 
-    mirrors:
-      uri: "mirrors/mirrors.dart"
-      patches: "_internal/js_runtime/lib/mirrors_patch_cfe.dart"
-      supported: false
-
     typed_data:
       uri: "typed_data/typed_data.dart"
       patches: "_internal/js_runtime/lib/typed_data_patch.dart"
@@ -392,9 +382,6 @@ dartdevc:
       _js_helper:
         uri: "_internal/js_dev_runtime/private/js_helper.dart"
 
-      _js_mirrors:
-        uri: "_internal/js_dev_runtime/private/js_mirrors.dart"
-
       _js_primitives:
         uri: "_internal/js_dev_runtime/private/js_primitives.dart"
 
@@ -434,11 +421,6 @@ dartdevc:
         patches: "_internal/js_dev_runtime/patch/isolate_patch.dart"
         supported: false
 
-      mirrors:
-        uri: "mirrors/mirrors.dart"
-        patches: "_internal/js_dev_runtime/patch/mirrors_patch.dart"
-        supported: false
-
       math:
         uri: "math/math.dart"
         patches: "_internal/js_dev_runtime/patch/math_patch.dart"
diff --git a/sdk_nnbd/lib/libraries.json b/sdk_nnbd/lib/libraries.json
@@ -217,11 +217,6 @@
         "uri": "../../sdk/lib/math/math.dart",
         "patches": "../../sdk/lib/_internal/js_runtime/lib/math_patch.dart"
       },
-      "mirrors": {
-        "uri": "../../sdk/lib/mirrors/mirrors.dart",
-        "patches": "../../sdk/lib/_internal/js_runtime/lib/mirrors_patch_cfe.dart",
-        "supported": false
-      },
       "typed_data": {
         "uri": "typed_data/typed_data.dart",
         "patches": "_internal/js_runtime/lib/typed_data_patch.dart"
@@ -327,11 +322,6 @@
         "uri": "../../sdk/lib/math/math.dart",
         "patches": "../../sdk/lib/_internal/js_runtime/lib/math_patch.dart"
       },
-      "mirrors": {
-        "uri": "../../sdk/lib/mirrors/mirrors.dart",
-        "patches": "../../sdk/lib/_internal/js_runtime/lib/mirrors_patch_cfe.dart",
-        "supported": false
-      },
       "typed_data": {
         "uri": "typed_data/typed_data.dart",
         "patches": "_internal/js_runtime/lib/typed_data_patch.dart"
@@ -399,9 +389,6 @@
       "_js_helper": {
         "uri": "_internal/js_dev_runtime/private/js_helper.dart"
       },
-      "_js_mirrors": {
-        "uri": "_internal/js_dev_runtime/private/js_mirrors.dart"
-      },
       "_js_primitives": {
         "uri": "_internal/js_dev_runtime/private/js_primitives.dart"
       },
@@ -441,11 +428,6 @@
         "patches": "_internal/js_dev_runtime/patch/isolate_patch.dart",
         "supported": false
       },
-      "mirrors": {
-        "uri": "mirrors/mirrors.dart",
-        "patches": "_internal/js_dev_runtime/patch/mirrors_patch.dart",
-        "supported": false
-      },
       "math": {
         "uri": "math/math.dart",
         "patches": "_internal/js_dev_runtime/patch/math_patch.dart"
diff --git a/sdk_nnbd/lib/libraries.yaml b/sdk_nnbd/lib/libraries.yaml
@@ -214,11 +214,6 @@ dart2js:
       uri: "../../sdk/lib/math/math.dart"
       patches: "../../sdk/lib/_internal/js_runtime/lib/math_patch.dart"
 
-    mirrors:
-      uri: "../../sdk/lib/mirrors/mirrors.dart"
-      patches: "../../sdk/lib/_internal/js_runtime/lib/mirrors_patch_cfe.dart"
-      supported: false
-
     typed_data:
       uri: "typed_data/typed_data.dart"
       patches: "_internal/js_runtime/lib/typed_data_patch.dart"
@@ -322,11 +317,6 @@ dart2js_server:
       uri: "../../sdk/lib/math/math.dart"
       patches: "../../sdk/lib/_internal/js_runtime/lib/math_patch.dart"
 
-    mirrors:
-      uri: "../../sdk/lib/mirrors/mirrors.dart"
-      patches: "../../sdk/lib/_internal/js_runtime/lib/mirrors_patch_cfe.dart"
-      supported: false
-
     typed_data:
       uri: "typed_data/typed_data.dart"
       patches: "_internal/js_runtime/lib/typed_data_patch.dart"
@@ -392,9 +382,6 @@ dartdevc:
       _js_helper:
         uri: "_internal/js_dev_runtime/private/js_helper.dart"
 
-      _js_mirrors:
-        uri: "_internal/js_dev_runtime/private/js_mirrors.dart"
-
       _js_primitives:
         uri: "_internal/js_dev_runtime/private/js_primitives.dart"
 
@@ -434,11 +421,6 @@ dartdevc:
         patches: "_internal/js_dev_runtime/patch/isolate_patch.dart"
         supported: false
 
-      mirrors:
-        uri: "mirrors/mirrors.dart"
-        patches: "_internal/js_dev_runtime/patch/mirrors_patch.dart"
-        supported: false
-
       math:
         uri: "math/math.dart"
         patches: "_internal/js_dev_runtime/patch/math_patch.dart"
diff --git a/tests/co19_2/co19_2-dart2js.status b/tests/co19_2/co19_2-dart2js.status
@@ -2,6 +2,15 @@
 # for details. All rights reserved. Use of this source code is governed by a
 # BSD-style license that can be found in the LICENSE file.
 
+[ $compiler == dart2js ]
+Language/Expressions/Null/instance_of_class_null_t01: Skip # dart:mirrors not supported https://github.com/dart-lang/co19/issues/522.
+Language/Expressions/Spawning_an_Isolate/new_isolate_t01: SkipByDesign
+Language/Metadata/before*: Skip # dart:mirrors not supported https://github.com/dart-lang/co19/issues/523.
+LayoutTests/*: Skip # These tests are going to be removed.
+LibTest/io/*: SkipByDesign # dart:io not supported.
+LibTest/isolate/*: SkipByDesign # dart:isolate not supported.
+WebPlatformTest/*: Skip # These tests are going to be removed.
+
 [ $compiler == dart2js && $runtime == d8 ]
 LayoutTests/*: SkipByDesign # d8 is not a browser
 LibTest/html/*: SkipByDesign # d8 is not a browser
@@ -27,10 +36,3 @@ LibTest/collection/ListMixin/ListMixin_class_A01_t06: SkipSlow # slow babeljs tr
 LibTest/core/List/List_class_A01_t04: SkipSlow # slow babeljs transformation
 LibTest/core/List/List_class_A01_t05: SkipSlow # slow babeljs transformation
 LibTest/core/List/List_class_A01_t06: SkipSlow # slow babeljs transformation
-
-[ $compiler == dart2js || $compiler == dartdevc || $compiler == dartdevk ]
-Language/Expressions/Spawning_an_Isolate/new_isolate_t01: SkipByDesign
-LayoutTests/*: Skip # These tests are going to be removed.
-LibTest/io/*: SkipByDesign # dart:io not supported.
-LibTest/isolate/*: SkipByDesign # dart:isolate not supported.
-WebPlatformTest/*: Skip # These tests are going to be removed.
diff --git a/tests/co19_2/co19_2-dartdevc.status b/tests/co19_2/co19_2-dartdevc.status
