record and print the original stack trace for argument errors

Change-Id: I5d3e5421bc06547463c060ecf70cecd773c1a753
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/341701
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Jake Macdonald <[email protected]>
Auto-Submit: Jake Macdonald <[email protected]>

Author: jakemac53

pkg/_fe_analyzer_shared/lib/src/macros/executor/executor_base.dart

@@ -225,11 +225,12 @@ abstract class ExternalMacroExecutorBase extends MacroExecutor {
                 requestId: requestId,
                 responseType: resultType,
                 serializationZoneId: zoneId);
-          } on ArgumentError catch (error) {
+          } on ArgumentError catch (error, stackTrace) {
             // TODO: Something better here.
             if (requestId == null) rethrow;
             response = new SerializableResponse(
                 error: '$error',
+                stackTrace: '$stackTrace',
                 requestId: requestId,
                 responseType: MessageType.argumentError,
                 serializationZoneId: zoneId);

pkg/_fe_analyzer_shared/lib/src/macros/executor/protocol.dart

@@ -101,6 +101,8 @@ class SerializableResponse implements Response, Serializable {
       case MessageType.argumentError:
         deserializer.moveNext();
         error = deserializer.expectString();
+        deserializer.moveNext();
+        stackTrace = deserializer.expectNullableString();
         break;
       case MessageType.macroInstanceIdentifier:
         response = new MacroInstanceIdentifierImpl.deserialize(deserializer);
@@ -150,6 +152,7 @@ class SerializableResponse implements Response, Serializable {
         break;
       case MessageType.argumentError:
         serializer.addString(error!.toString());
+        serializer.addNullableString(stackTrace?.toString());
         break;
       default:
         response.serializeNullable(serializer);
@@ -792,7 +795,8 @@ T _handleResponse<T>(Response response) {
   if (response.responseType == MessageType.error) {
     throw new RemoteException(response.error!.toString(), response.stackTrace);
   } else if (response.responseType == MessageType.argumentError) {
-    throw new ArgumentError(response.error!.toString());
+    throw new ArgumentError('${response.error!.toString()}'
+        '${response.stackTrace == null ? '' : '\n\n${response.stackTrace}'}');
   }
 
   return response.response as T;